[Patches] [Patch #101844] bdist_wininst creates corrupt installations
noreply@sourceforge.net
noreply@sourceforge.net
Mon, 9 Oct 2000 13:44:51 -0700
Patch #101844 has been updated.
Project:
Category: distutils
Status: Open
Summary: bdist_wininst creates corrupt installations
Follow-Ups:
Date: 2000-Oct-09 11:13
By: theller
Comment:
[Martin von Loewis]
> I've created a PyXML distribution with recent distutils (0.93 and
> 1.0). When installing these distributions, the installer creates empty
> files only, see
>
> http://download.sourceforge.net/pyxml/PyXML-0.6.0.win32.exe
>
> for an example.
>
> I've tracked this down to usage of the zipfile module. If it does not
> find an external zip program (which I did not have), it then tries to
> use the zipfile module. Somehow, the installation program later cannot
> process the files created with that module.
>
> The problem is probably in the installer, since Winzip 7 is capable of
> reading the package, and extracts the files properly.
>
> I have solved the problem by installing infozip on my
> machine. However, I'd appreciate if somebody could look into the
> problem and let me know what the cause is. If you cannot reproduce the
> problem, please let me know as well.
>
The problem was that the windows installer was using zipfile datastructures
which are not always set.
The following patch fixes this problem.
Since currently I cannot check in these changes, I'm posting them here
so they do not get lost.
Note that wininst.exe must be recompiled and bdist_wininst.py
must be regenerated to complete the fix.
Thomas
-------------------------------------------------------
Date: 2000-Oct-09 12:28
By: gvanrossum
Comment:
Hopefully Greg Ward will eb back to review this before 2.0 *final* goes out on Oct 16.
-------------------------------------------------------
Date: 2000-Oct-09 12:54
By: akuchling
Comment:
Greg is supposed to be getting back around Friday the 13th. (Hmmm...) So the schedule will be tight, but I don't think Greg can do much checking on the Windows install; since the patch is from Thomas, he'll probably just trust it.
-------------------------------------------------------
Date: 2000-Oct-09 13:44
By: jhylton
Comment:
Thomas,
I have no idea how to apply this patch. I can't find the files mentioned anywhere in the Python CVS tree.
-------------------------------------------------------
-------------------------------------------------------
For more info, visit:
http://sourceforge.net/patch/?func=detailpatch&patch_id=101844&group_id=5470