[Patches] [Patch #102170] move getopt() to Py_GetOpt() and use it unconditionally

noreply@sourceforge.net noreply@sourceforge.net
Wed, 1 Nov 2000 04:45:05 -0800


Patch #102170 has been updated. 

Project: python
Category: core (C code)
Status: Open
Summary: move getopt() to Py_GetOpt() and use it unconditionally

Follow-Ups:

Date: 2000-Oct-30 09:48
By: twouters

Comment:
This patch attempts to do what Tim suggested in the python-dev thread about getopt()'s prototype and the difficulties of it. the 'getopt' implementation as provided in Python/getopt.c is renamed to Py_GetOpt(), the exported variables 'opterr', 'optind' and 'optarg' are prefixed with Py_, and all use in the Python sourcetree is adjusted.

The patch is missing the 'pygetopt.h' include file, though :P I'll resubmit a proper patch later. 

There are a couple of issues still open: the name of the getopt.c file, its use of 'fprintf(stderr, ... )', its license, documentation (which this patch lacks) and whether this Py_GetOpt should be an officially exported API at all.


-------------------------------------------------------

Date: 2000-Oct-30 10:08
By: twouters

Comment:
New patch, includes pygetopt.h by hack. (not sure if it patches cleanly, but it's not that exciting a file anyway :) Assigned to.... (spin wheel... Guido. no. spin wheel... Barry. no. spin wheel... Moshe. dang. spin wheel... *nudge*. Ah, finally,) Tim.


-------------------------------------------------------

Date: 2000-Nov-01 04:45
By: moshez

Comment:
Well, as the one who almost got the assignment <wink>, I'm +1 on it. Using native getopt is more trouble then it's worth, especially considering the fact that we've had an implementation of our own for so long. So here's for reinventing the wheel! <wink>
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=102170&group_id=5470