[Patches] [Patch #100740] gzip: readline(), readlines() patch

[noreply@sourceforge.net]

Patch #100740 has been updated. 

Project: 
Category: None
Status: Rejected
Summary: gzip: readline(), readlines() patch

Follow-Ups:

Date: 2000-Jul-05 18:15
By: akuchling

Comment:
Patch from Wolfgang Grafen <wolfgang.grafen@marconicomms.com> that I didn't want to lose.  From his e-mail:

- readline accepts readsize argument
- readlines accepts readsize argument
- readlines accepts optional 'strip_cr' arguments, which is often convenient for me and also speeds up the routine :)

[amk] The strip_cr thing is a non-starter, but I'll look at adding the other changes.
-------------------------------------------------------

Date: 2000-Jul-27 13:03
By: gvanrossum

Comment:
His addition of readsize to readline() doesn't do the same as readline(n) does for regular files -- there it reads at most n characters, period.

The only part of this patch I like is the readsize argument to readlines(), which *does* (roughly) do the same as for regular files.

You can rework this to implement readline(maxread=-1) and readlines(sizehint=0) and then I'd be okay.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=100740&group_id=5470