[Patches] Re: [Mailman-Developers] Bug#57223: mailman: gate_news problems (fwd)

[Thomas Wouters]

On Tue, Feb 08, 2000 at 06:18:14PM -0500, bwarsaw@cnri.reston.va.us wrote:

> I'm not sure what to do about the email disclaimers, but I'd say to be
> safe that both Jim and Thomas should re-submit their patches with the
> disclaimer attached (you can just to this to patches@python.org).

Mine already had the disclaimer attached. Let me know if i did that wrong ;)
I'd like to make one little suggestion for your docstring, though.

"""
readermode is sometimes necessary if you are connecting to an NNTP server on
your local machine and intend to call the group() method.
"""

Group isn't the only reader-specific command. Commands such as 'listgroup
<group>' and 'xover <group>' are nnrpd-specific, as well. (at least on the
only newsserver I can currently test with.) I'd suggest this:

"""
readermode is sometimes necessary if you are connecting to an NNTP server on
your local machine and intend to call reader-specific commands, such as
'group'.
"""

And dont forget to mention something like 'if you get unexpected
NNTPPermanentErrors, you might need to set readermode.'

-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!