[Patches] [Patch #102955] bltinmodule.c warning fix
noreply@sourceforge.net
noreply@sourceforge.net
Tue, 19 Dec 2000 19:02:05 -0800
Patch #102955 has been updated.
Project: python
Category: core (C code)
Status: Accepted
Submitted by: akuchling
Assigned to : akuchling
Summary: bltinmodule.c warning fix
Follow-Ups:
Date: 2000-Dec-19 19:02
By: tim_one
Comment:
I *am* damned cute, and glad someone finally appreciates that. Had to laugh at "simplifies ord()'s logic" -- you'd sure hope that a function as trivial as ord() had no logic to be simplified ...
Unrelated to your patch but in the same area: the other msg, "ord() expected string or Unicode character", doesn't read right. The type names in question are "string" and "unicode":
>>> type("")
<type 'string'>
>>> type(u"")
<type 'unicode'>
>>>
"character" is out of place, or not in enough places. Just thought I'd mention that, since *you're* so cute!
-------------------------------------------------------
Date: 2000-Dec-19 18:13
By: akuchling
Comment:
Fix for one of the warnings in bug #121479:
bltinmodule.c: In function `builtin_ord':
bltinmodule.c:1507: warning: `ord' might be used uninitialized in this function
The patch simplifies ord()'s logic at the cost of some code duplication. Randomly assigning to Tim 'cause he's soooo cute.
-------------------------------------------------------
-------------------------------------------------------
For more info, visit:
http://sourceforge.net/patch/?func=detailpatch&patch_id=102955&group_id=5470