[Patches] Please review before applying
Greg Stein
gstein@lyra.org
Sat, 22 Apr 2000 12:32:39 -0700 (PDT)
On Fri, 21 Apr 2000, Guido van Rossum wrote:
>...
> > Shouldn't we be consequent and use the new startswith methods
> > as well, instead of if version[:5] != 'HTTP/' ?
> > I think it would be better to do this all in one big shot.
>
> No, I think it's fine to do it in one fell swoop. You can either make
> many of this kind of changes to one module or make one type of change
> to many modules; if you try both, you'll touch too much and start
> making mistakes.
I'm with Guido on this one. If you are making a *large* set of patches,
then it is best to stick with a single type of change. Fred's patch is
generally a simple translation: string.foo(s, ...) => s.foo(...)
Any more than that, and your brain has to keep changing gears.
A second round of patching can easily go through and make use of the new
.startswith().
Cheers,
-g
--
Greg Stein, http://www.lyra.org/