[Pandas-dev] PDEPs: pandas enhancement proposals

[Tom Augspurger]

For me, notifications are the big thing. Having the emails come from a separate repo would make following things much easier for those who can’t keep up with the main repo.

Tom

> On Jun 25, 2022, at 12:04 PM, Marc Garcia <garcia.marc at gmail.com> wrote:
> 
> 
> Thanks for the feedback. I understand your point about using a different repo, but I see several advantages on the current approach, so maybe worth discussing a bit further what are the exact pain points, to see if a separate repo is really the best solution.
> 
> Let me know if I miss something, but I see three different ways in which we'll be interacting with PDEPs:
> 
> a) Via their rendered version. Not sure if you checked it, but the current rendered page from the PDEP PR (attached) is equivalent to the home of the scikit-learn SLEP proposals [1]. The main difference is that with the current approach we have it integrated with the website, which I personally think it's an advantage.
> 
> b) Via the list of PDEP PRs to review. In this case, to see only PDEP PRs, if we use the main pandas repo, this is just a label filter [2]. To me personally quicker than having to go to another repo, but no big difference about one or the other.
> 
> c) Notifications. I guess this is the main thing. I think one concern is that notifications from PDEPs get lost in the rest of the repo notifications. I assume you're using your email client filters, and if the notifications come from another repo, you can change the rules easily. I guess the solution here would be to use something like PDEP in the title and use that as a rule. Or we can try to find something more reliable, if that's the main concern.
> 
> Personally, I don't see the advantages of having the proposals in a separate repo very significant. And by keeping things the way they're implemented in the PR, I do see some advantages:
> - No need to maintain a separate repo, CI workflow, jobs to publish the build, sphinx (or equivalent) project... Nothing too complex, by why having to implement and maintain all that if our website is already prepared to handle it. And in particular, with Sphinx is not as easy as with out website to fetch the open PRs and render them.
> - Integrated UX of the PDEPs into our website. I think this gives it more visibility, and a better using experience than having to jump from one website to another.
> - One of my concerns is that being in a separate repo we forget about them. We're used to check PRs in the pandas repo, and we'll keep coming back to PRs about PDEPs until they're merged if they are in the main repo, but feels like being in a separate repo is easier to forget them when there is no recent activity and notifications.
> 
> It would be good to know if I miss any of your concerns. If I didn't, I'd say we can start with what's already implemented, which is almost ready to get merged, and if in the future you still think we can do better by using a separate repo, you can implement it, we have a discussion about it, and we move PDEPs to a separate repo if that makes sense. What do you think?
> 
> Cheers,
> Marc
> 
> 1. https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/
> 2. https://github.com/pandas-dev/pandas/pulls?q=is%3Aopen+is%3Apr+label%3APDEP
> 
> 
>> On Sat, Jun 25, 2022 at 7:05 AM Jeff Reback <jeffreback at gmail.com> wrote:
>> +1 in using a separate repo (under pandas-dev) for this
>> 
>>> 
>>>> On Jun 24, 2022, at 5:05 PM, Joris Van den Bossche <jorisvandenbossche at gmail.com> wrote:
>>>> 
>>> 
>>> Thanks for starting this proposal, Marc!
>>> 
>>> I have already been doing this in some ad-hoc way with eg the Copy/View proposal (writing an actual proposal document), so I am very much in favor of formalizing this a bit more. 
>>> 
>>> Personally, I would prefer that we use a more dedicated home for this instead of using the existing pandas repo (e.g. a separate repo in the pandas-dev org). The main pandas repo has nowadays such a high volume in issue and PR comments, that it becomes difficult to follow this or notice specific issues. While there are certainly ways to deal with this (e.g. consistently using a specific label and title, ensuring we always notify the mailing list as well, ...), IMO it would make it more accessible to follow and have an overview of those discussions in e.g. a separate repo.
>>> 
>>> (there are examples of both in other projects, for example scikit-learn has a separate repo, while bumpy uses the main repo I think)
>>> 
>>> Joris
>>> 
>>> Op di 21 jun. 2022 09:46 schreef Marc Garcia <garcia.marc at gmail.com>:
>>>> We're in the process of implementing PDEPs, equivalent to Python's PEPs and NumPy's NEPs, but for pandas. This should help build the roadmap, make discussions more efficient, obtain more structured feedback from the community, and add visibility to agreed future plans for pandas.
>>>> 
>>>> The initial implementation (workflow) is a bit simpler than PEP or NEP, but we'll iterate in the future as convenient.
>>>> 
>>>> You can see the PR for PDEP-1 with the purpose, scope and guidelines here: https://github.com/pandas-dev/pandas/pull/47444
>>>> 
>>>> Feedback is very welcome.
>>>> _______________________________________________
>>>> Pandas-dev mailing list
>>>> Pandas-dev at python.org
>>>> https://mail.python.org/mailman/listinfo/pandas-dev
>>> _______________________________________________
>>> Pandas-dev mailing list
>>> Pandas-dev at python.org
>>> https://mail.python.org/mailman/listinfo/pandas-dev
> _______________________________________________
> Pandas-dev mailing list
> Pandas-dev at python.org
> https://mail.python.org/mailman/listinfo/pandas-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.python.org/pipermail/pandas-dev/attachments/20220625/d17a896b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot at 2022-06-25 22-20-50.png
Type: image/png
Size: 192689 bytes
Desc: not available
URL: <https://mail.python.org/pipermail/pandas-dev/attachments/20220625/d17a896b/attachment-0001.png>