From jorisvandenbossche at gmail.com Wed Apr 11 12:04:53 2018 From: jorisvandenbossche at gmail.com (Joris Van den Bossche) Date: Wed, 11 Apr 2018 18:04:53 +0200 Subject: [Pandas-dev] Pandas development meeting - Thursday April 11 at 14:00 UTC+1 Message-ID: Hi all, We're having a dev chat tomorrow (Thursday April 12) at 9:00 Eastern / 14:00 UTC+1. All are welcome to attend! Hangout: https://hangouts.google.com/call/dZwI-GH3KYPG8Ayu2fiUAAEI Minutes: https://docs.google.com/document/d/1tGbTiYORHiSPgVMXawiweGJlBw5dO kVJLY-licoBmBU/edit?usp=sharing Joris -------------- next part -------------- An HTML attachment was scrubbed... URL: From jorisvandenbossche at gmail.com Fri Apr 20 12:24:10 2018 From: jorisvandenbossche at gmail.com (Joris Van den Bossche) Date: Fri, 20 Apr 2018 18:24:10 +0200 Subject: [Pandas-dev] Pandas dev sprint July 5-8 (pre-Scipy Conf) Message-ID: Dear all, We are planning to do a pandas sprint just before the Scipy Conference (which is in Austin, Texas, July 9-13). The sprint would then be from July 5 or 6 to July 8, also in Austin. We will meet there with some of the core devs, but we also want to invite other pandas (or related libraries) contributors. Note: the sprint is not meant to jump-start newcomers to contributing to open source (for that, there is a sprint at the end of the Scipy). The exact planning of the sprint still needs to be discussed (will open a separate thread for that), but topics will probably include: general issue clean-up, discussing project management, roadmap to pandas 1.0 (what do we still want to get in / change before that) and evolution of pandas afterwards, ... and of course actual coding. *So if you are interested, certainly let something know! * We probably want to keep it somewhat limited in number, but don't hesitate to state your interest. If you would like to participate, but not sure if you would fit at such a sprint, don't hesitate to mail me personally. If you would like to participate, but would need financial support, you can also mail me (we might have some funds, but not fully sure yet). Best, Joris -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at pietrobattiston.it Tue Apr 24 21:41:19 2018 From: me at pietrobattiston.it (Pietro Battiston) Date: Wed, 25 Apr 2018 03:41:19 +0200 Subject: [Pandas-dev] Commit messages Message-ID: <1524620479.28234.41.camel@pietrobattiston.it> Hi all, I'm a bit confused by the last PR I merged (7ec74e5f). I was erroneously assuming that the part of commit messages such as: Closes #00000 from johnsmith/abc and squashes the following commits: xxxxxx [John Smith] first yyyyyy [John Smith] second ... was automatically added by Github when squashing. Instead it's apparently not the case. How do you typically create those commit messages? With the green button or locally? Do you manually write their entire content? Pietro From jorisvandenbossche at gmail.com Wed Apr 25 03:39:55 2018 From: jorisvandenbossche at gmail.com (Joris Van den Bossche) Date: Wed, 25 Apr 2018 09:39:55 +0200 Subject: [Pandas-dev] Commit messages In-Reply-To: <1524620479.28234.41.camel@pietrobattiston.it> References: <1524620479.28234.41.camel@pietrobattiston.it> Message-ID: Hi Pietro, No, the github interface does not create such a commit message (it sometimes puts all the individual commit messages in the body, but without the details of the author and the hash for each squashed commit). It was our script (scripts/merge-pr.py) that created such commit messages, but nowadays we usually don't use that anymore, but rather use the green merge button on github itself. What I often do is edit the body of the generated commit message by github a little bit (eg if many of the individual squashed commit messages are "edit", "fixup", etc I just remove them, or otherwise keep the informative part), but nothing too fancy. Github always adds the PR number to commit title, so that way you can easily get back to the PR to look at individual squased commits if needed. Joris 2018-04-25 3:41 GMT+02:00 Pietro Battiston : > Hi all, > > I'm a bit confused by the last PR I merged (7ec74e5f). I was > erroneously assuming that the part of commit messages such as: > > > Closes #00000 from johnsmith/abc and squashes the following commits: > > xxxxxx [John Smith] first > yyyyyy [John Smith] second > > > ... was automatically added by Github when squashing. Instead it's > apparently not the case. > > How do you typically create those commit messages? With the green > button or locally? Do you manually write their entire content? > > Pietro > _______________________________________________ > Pandas-dev mailing list > Pandas-dev at python.org > https://mail.python.org/mailman/listinfo/pandas-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at pietrobattiston.it Wed Apr 25 06:19:24 2018 From: me at pietrobattiston.it (Pietro Battiston) Date: Wed, 25 Apr 2018 12:19:24 +0200 Subject: [Pandas-dev] Commit messages In-Reply-To: References: <1524620479.28234.41.camel@pietrobattiston.it> Message-ID: <1524651564.28234.51.camel@pietrobattiston.it> Thanks?Jeff and Joris, I guess I know have a much clearer understanding - and less?expectation for magic. Pietro Il giorno mer, 25/04/2018 alle 09.39 +0200, Joris Van den Bossche ha scritto: > Hi Pietro, > > No, the github interface does not create such a commit message (it > sometimes puts all the individual commit messages in the body, but > without the details of the author and the hash for each squashed > commit). > It was our script (scripts/merge-pr.py) that created such commit > messages, but nowadays we usually don't use that anymore, but rather > use the green merge button on github itself. > > What I often do is edit the body of the generated commit message by > github a little bit (eg if many of the individual squashed commit > messages are "edit", "fixup", etc I just remove them, or otherwise > keep the informative part), but nothing too fancy. Github always adds > the PR number to commit title, so that way you can easily get back to > the PR to look at individual squased commits if needed. > > Joris > > > > 2018-04-25 3:41 GMT+02:00 Pietro Battiston : > > Hi all, > > > > I'm a bit confused by the last PR I merged (7ec74e5f). I was > > erroneously assuming that the part of commit messages such as: > > > > > > ? ?Closes #00000 from johnsmith/abc and squashes the following > > commits: > > > > ? ?xxxxxx [John Smith] first > > ? ?yyyyyy [John Smith] second > > > > > > ... was automatically added by Github when squashing. Instead it's > > apparently not the case. > > > > How do you typically create those commit messages? With the green > > button or locally? Do you manually write their entire content? > > > > Pietro > > _______________________________________________ > > Pandas-dev mailing list > > Pandas-dev at python.org > > https://mail.python.org/mailman/listinfo/pandas-dev > > > >