[Pandas-dev] A dedicated place for pandas 2.0 pull requests and code reviews?

Wes McKinney wesmckinn at gmail.com
Wed Oct 12 18:52:37 EDT 2016


You're right -- it would be good to have the PRs and design
discussions in one place as there will be a lot of interconnectedness.
I don't think there will be a ton of PRs, at most a few each week to
start. I'll rename pandas-design to pandas-dev/pandas2 and create a
pandas-2.0 code branch there

On Wed, Oct 12, 2016 at 5:54 PM, Joris Van den Bossche
<jorisvandenbossche at gmail.com> wrote:
> I think it is a good idea to keep it separate in the beginning, the pandas
> repo itself is already noisy enough :-)
>
> Only concern: when we start discussing PRs or issues in a pandas2 repo, the
> distinction with the discussions on pandas-design may start to become
> unclear.
> Would it be an option to have the prototyping in a subdirectory of the
> pandas-design repo itself? On the other hand, the discussions on those PRs
> may also get too noisy for the people who want to follow the more high-level
> stuff on pandas-design.
>
> Joris
>
> 2016-10-12 23:18 GMT+02:00 Wes McKinney <wesmckinn at gmail.com>:
>>
>> hi folks
>>
>> We have https://github.com/pydata/pandas-design already, but: I'm
>> starting to get to work on some prototyping:
>>
>> https://github.com/wesm/pandas/tree/pandas-2.0
>>
>> Rather than clutter up pydata/pandas with the PRs, code reviews, and
>> occasionally unstable builds for this, I'm thinking of creating
>> pydata/pandas2 (a new repo, but the same git repository as
>> pydata/pandas) and putting up PRs there, and Gerrit code reviews
>> (going to try out gerrithub.io -- I want a lot of scrutiny on this
>> code). Does this sound like a good idea? This will also help others
>> who want to engage in the pandas 2.0 process but not the pandas
>> day-to-day grind.
>>
>> When I reach some checkpoints where design feedback is necessary to
>> move forward I can make some noise there. Going to be mostly essential
>> C++ plumbing (memory management, array reference counting, views,
>> etc.) for the next few weeks.
>>
>> Let me know what you all think.
>>
>> As an aside, as I've started working on this, it's reasonably clear
>> that we're going to want to commit to the copy-on-write path pretty
>> early in the process. Luckily I don't think this is very hard once you
>> can easily determine when there is array data sharing. We may want to
>> explore that topic in some detail in the design docs
>>
>> Thanks
>> Wes
>> _______________________________________________
>> Pandas-dev mailing list
>> Pandas-dev at python.org
>> https://mail.python.org/mailman/listinfo/pandas-dev
>
>


More information about the Pandas-dev mailing list