[Numpy-svn] [numpy/numpy] 1b88f0: BUG: Fix genfromtext NameValidator arguments passe...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: 1b88f08b4f27e26adc7a1200a51974eb5bf719e0
      https://github.com/numpy/numpy/commit/1b88f08b4f27e26adc7a1200a51974eb5bf719e0
  Author: Alan Briolat <alan.briolat at gmail.com>
  Date:   2015-01-23 (Fri, 23 Jan 2015)

  Changed paths:
    M numpy/lib/npyio.py
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  BUG: Fix genfromtext NameValidator arguments passed to easy_dtype.

np.genfromtxt validates field names twice: once in genfromtxt and once
in easy_dtype. Whilst the arguments to genfromtxt are used in the first
validation, they aren't passed to easy_dtype (which is used only when
dtype != None) and therefore in this case the default validation (strip
non-alphanum, replace spaces) gets confusingly applied, ignoring
genfromtxt's arguments.

This patch adds fixes genfromtxt by passing the appropriate arguments
onwards to easy_dtype.  That is probably the least invasive way to fix
the issue.


  Commit: 4b1aab31cc66d4a5abd3d2d6b40e461cadd79d2a
      https://github.com/numpy/numpy/commit/4b1aab31cc66d4a5abd3d2d6b40e461cadd79d2a
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-01-23 (Fri, 23 Jan 2015)

  Changed paths:
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  TST: Fix bug in test_dtype_with_converters_and_usecols.

The case_sensitive argument to np.recfromcsv has a default value of
'lower'. That value was not previously correctly passed on, but is
now, so the previous expected values in this test were incorrectly
upper cased.


  Commit: 6bb48b0639322a0f5908996f33c98db62304b839
      https://github.com/numpy/numpy/commit/6bb48b0639322a0f5908996f33c98db62304b839
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-01-23 (Fri, 23 Jan 2015)

  Changed paths:
    M numpy/lib/_iotools.py
    M numpy/lib/tests/test__iotools.py

  Log Message:
  -----------
  MAINT: Make argument determination in NameValidator more precise.

The function was useing `'u' in case_sensitive` to detect `upper`.
Make that more precise with `case_sensitive.startswith('u').

Raise ValueError if case_sensitive has unrecognized value.


  Commit: e1ff6268a2e256bdb6cf6c06457456c7c4bd495d
      https://github.com/numpy/numpy/commit/e1ff6268a2e256bdb6cf6c06457456c7c4bd495d
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M numpy/lib/_iotools.py
    M numpy/lib/npyio.py
    M numpy/lib/tests/test__iotools.py
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  Merge pull request #5495 from charris/cleanup-gh-4649

BUG: Fix genfromtext NameValidator arguments passed to easy_dtype.


Compare: https://github.com/numpy/numpy/compare/22f2dc50fdd3...e1ff6268a2e2