[Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

[Gagandeep Singh]

Hi,

I have removed the two new C functions
<https://github.com/numpy/numpy/pull/19211/commits/4be86dd0400d4f52fd72dbc312d69942fd5f7c73>
from public C-API. Let me know if anything else is needed.

Thanks.

On Fri, Jul 2, 2021 at 2:10 AM Matti Picus <matti.picus at gmail.com> wrote:

>
> On 1/7/21 7:49 pm, Gagandeep Singh wrote:
> > Hi,
> >
> > So should I remove these new functions from public C-API? Let me know.
> > I will do that.
> >
> >
>
> Yes please. If needed we can add them, but once in we cannot remove them.
>
> Matti
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.python.org/pipermail/numpy-discussion/attachments/20210702/94bbfe0d/attachment.html>