[Numpy-discussion] Commit rights on github

[Charles R Harris]

On Mon, Oct 11, 2010 at 7:31 PM, David <david at silveregg.co.jp> wrote:

> On 10/12/2010 08:48 AM, Charles R Harris wrote:
> >
> >
> > On Mon, Oct 11, 2010 at 5:09 PM, Pierre GM <pgmdevlist at gmail.com
> > <mailto:pgmdevlist at gmail.com>> wrote:
> >
> >
> >     On Oct 12, 2010, at 1:06 AM, Pauli Virtanen wrote:
> >
> >      > Mon, 11 Oct 2010 23:30:31 +0200, Pierre GM wrote:
> >      >> Would any of you mind giving me commit rights on github? My
> >     handle is
> >      >> pierregm. Thanks a million in advance.
> >      >
> >      > Granted.
> >
> >     Got it, thanks again!
> >
> >
> > Umm, I think your first commit changed a lot more than you intended.
>
> Indeed. Pierre, please revert this commit, and then commit what you
> intended:
>
> git revert a14dd542532d383610c1b01c5698b137dd058fea -m 2 # will revert
> all your changes
> git cherry-pick -n 61d945bdb5c9b2b3329e1b8468b5c7d0596dd9fc # apply the
> changes introduced by 61d945..., but do not commit
>
> Then, check that you don't add unnecessary files (eclipse files) before
> committing again. A good way to check what you are about to commit is to
> do git diff --stat --cached,
>
>
I can't quite figure out what commit
a14dd542532d383610c1<http://github.com/numpy/numpy/commit/a14dd542532d383610c1b01c5698b137dd058fea>did
or where it applied. Any hints?

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20101011/3e02691f/attachment.html>