[New-bugs-announce] [issue36096] IDLE: Refactor class variables to instance variables in colorizer
Cheryl Sabella
report at bugs.python.org
Sat Feb 23 17:53:18 EST 2019
New submission from Cheryl Sabella <cheryl.sabella at gmail.com>:
>From Terry's comment on PR11472 for issue 35689:
> I don't like the use of class variables to initialize volatile instance state variables. I think it confuses the code a bit. Better, I think, to put them in an `init_state` method called from `__init__`. (I am not sure if method could be used in tests.) Since the tests do not access the class vars directly on the class, they should not be affected. I am leaving this minor refactoring for another issue after merging the tests. Then we can modify the class docstring.
----------
assignee: terry.reedy
components: IDLE
messages: 336415
nosy: cheryl.sabella, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Refactor class variables to instance variables in colorizer
type: enhancement
versions: Python 3.7, Python 3.8
_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue36096>
_______________________________________
More information about the New-bugs-announce
mailing list