[New-bugs-announce] [issue34964] Make Tkinter sources more readable by adding blank lines

Serhiy Storchaka report at bugs.python.org
Fri Oct 12 09:42:07 EDT 2018


New submission from Serhiy Storchaka <storchaka+cpython at gmail.com>:

Tkinter sources are old and don't conform PEP 8. Usually we don't reformat existing sources for avoiding problems with backporting and breaking the history of lines. But I think that we can make some refinements in Tkinter sources.

The tkinter module contains a lot of small methods (often just 1 or 2 lines of code), but with large multiline docstrings. Currently methods are not separated by blank lines. As result, the code of the method is visually closer to the header of the following method that to the header of its method.

The proposed patch adds empty lines between methods and double empty lines between class (and removes few redundant empty lines). Most changes are made automatically:

    autopep8 --select E301,E303,E305 --in-place --recursive Lib/tkinter/

and edited after this (added missed empty lines and removed few unwanted changes).

Since it affects only empty lines, it doesn't break the lines history. And I think this will not make backporting more difficult.

----------
components: Library (Lib), Tkinter
messages: 327585
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: Make Tkinter sources more readable by adding blank lines
type: enhancement
versions: Python 3.8

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue34964>
_______________________________________


More information about the New-bugs-announce mailing list