[New-bugs-announce] [issue33734] asyncio/ssl: Fix AttributeError, increase default handshake timeout

[Yury Selivanov]

New submission from Yury Selivanov <yselivanov at gmail.com>:

I've ported asyncio's sslproto.py to uvloop and released a new major version of it yesterday.  Hynek discovered that the default SSL handshake timeout (10 seconds currently) is too low, and that there's a critical code path that is broken because it assumes all SSL exceptions have an 'errno' attribute.

The PR changes the default SSL handshake timeout to 60 seconds (as in nginx [1]) and fixes the AttributeError.

IMO this should go into 3.7.0rc1.


[1] https://docs.nginx.com/nginx/admin-guide/security-controls/terminating-ssl-tcp/#speeding-up-secure-tcp-connections

----------
assignee: yselivanov
components: asyncio
messages: 318422
nosy: asvetlov, hynek, ned.deily, yselivanov
priority: release blocker
severity: normal
status: open
title: asyncio/ssl: Fix AttributeError, increase default handshake timeout
type: behavior
versions: Python 3.7, Python 3.8

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue33734>
_______________________________________