[New-bugs-announce] [issue35602] cleanup code may fail in test_asyncio.test_unix_events.SelectorEventLoopUnixSockSendfileTests

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado <pablogsal at gmail.com>:

According to this buildbot:

https://buildbot.python.org/all/#/builders/170/builds/218/steps/4/logs/stdio

there is some cleanup failure in test_sock_sendfile_os_error_first_call:

test_sock_sendfile_os_error_first_call (test.test_asyncio.test_unix_events.SelectorEventLoopUnixSockSendfileTests) ... /usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/asyncio/selector_events.py:655: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=10>
  source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
ok

The code that is supposed to clean up the resource is:

        def cleanup():
            if proto.transport is not None:
                # can be None if the task was cancelled before
                # connection_made callback
                proto.transport.close()
                self.run_loop(proto.wait_closed())

apparently, proto.transport may be None and then it fails to be closed even if the test succeeds (I assume because the condition in the comment happens or something else) and then the transport is not properly closed.

----------
components: Tests, asyncio
messages: 332642
nosy: asvetlov, pablogsal, yselivanov
priority: normal
severity: normal
status: open
title: cleanup code may fail in test_asyncio.test_unix_events.SelectorEventLoopUnixSockSendfileTests
versions: Python 3.6, Python 3.7, Python 3.8

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue35602>
_______________________________________