[New-bugs-announce] [issue32013] _pickle: Py_DECREF seems to be missing from a failure case in fast_save_enter()

[Mathew M.]

New submission from Mathew M. <mathew1800 at gmail.com>:

Hey there! I'm fairly new to the development process for Python, so I figured I'd start off with something tiny and then work on up from there. I'm not sure if this sort of minor fix warrants an issue being created, but I made this just to err on the safe side of things.

So, as far as I understand (by all means correct me if I'm wrong), a 'Py_DECREF(key);' should be present before the return in the conditional within fast_save_enter() (https://github.com/python/cpython/blob/d7d4fea4a39da4bfdea1de22fe040023eb4ddc17/Modules/_pickle.c#L1792)

----------
components: Extension Modules
messages: 306139
nosy: Mathew M.
priority: normal
severity: normal
status: open
title: _pickle: Py_DECREF seems to be missing from a failure case in fast_save_enter()
versions: Python 3.7

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue32013>
_______________________________________