[New-bugs-announce] [issue26348] activate.fish sets VENV prompt incorrectly

[Dan McCombs]

New submission from Dan McCombs:

Currently, the activate.fish VENV script sets fish's prompt to be prepended with a literal "__VENV_PROMPT__" rather than the contents of the $__VENV_PROMPT__ variable as intended.

The attached patch simply adds the missing "$" to the variable in the conditional test and it's usage, so it's only being set if the variable is non-zero, rather than testing if the string "__VENV_PROMPT__" is non-zero like it is doing right now.

The results in the prompt being correctly prepended by "(my_actual_venv_name)".

----------
components: Library (Lib)
files: activate-fish.patch
keywords: patch
messages: 260175
nosy: Dan McCombs
priority: normal
severity: normal
status: open
title: activate.fish sets VENV prompt incorrectly
type: behavior
versions: Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41907/activate-fish.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue26348>
_______________________________________