[New-bugs-announce] [issue24347] unchecked return value in C OrderedDict

[Eric Snow]

New submission from Eric Snow:

(from msg244574 in issue16991)

crash-1.py is due to an unchecked return value from _odictnode_VALUE().

We should probably use PyDict_GetItemWithError(), also in other
places.

I normally try to steer clear of stylistic remarks, but the
_odictnode* macros are hiding too many things.  As of now,
they were hiding that an assert() is always true and that a
return value was unchecked.

Also, they're very inconvenient in a debugger.

----------
assignee: eric.snow
components: Library (Lib)
files: crash-1.py
messages: 244597
nosy: eric.snow, skrah
priority: release blocker
severity: normal
stage: test needed
status: open
title: unchecked return value in C OrderedDict
type: crash
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file39588/crash-1.py

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24347>
_______________________________________