[New-bugs-announce] [issue21357] Increase filecmp test coverage from 63% to 76%

[diana]

New submission from diana:

- Increase filecmp test coverage from 63% to 76%

- I left the testing style as-is, though it could probably be modernized.

- I did not attempt to add coverage for 'funny_files', 'subdirs', etc, next pass perhaps.

- Before:

diana$ ./python.exe ../coveragepy report --show-missing
Name          Stmts   Miss  Cover   Missing
-------------------------------------------
Lib/filecmp     163     61    63%   64, 80, 126, 130, 159-161, 164-166, 172, 174, 178-180, 190-194, 197-199, 203-224, 227-230, 233-236, 246, 293-302, 305

- After:

diana$ ./python.exe ../coveragepy report --show-missing
Name          Stmts   Miss  Cover   Missing
-------------------------------------------
Lib/filecmp     163     39    76%   64, 80, 126, 130, 159-161, 164-166, 172, 174, 178-180, 192-194, 197-199, 217-218, 220-221, 223-224, 229-230, 235-236, 246, 293-302, 305

Thoughts? Thanks!

----------
components: Library (Lib)
files: increase_filecmp_test_coverage.patch
keywords: patch
messages: 217201
nosy: diana
priority: normal
severity: normal
status: open
title: Increase filecmp test coverage from 63% to 76%
type: behavior
versions: Python 3.5
Added file: http://bugs.python.org/file35045/increase_filecmp_test_coverage.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21357>
_______________________________________