[New-bugs-announce] [issue21141] Don't mention Perl in Windows build output

Zachary Ware report at bugs.python.org
Thu Apr 3 05:39:49 CEST 2014


New submission from Zachary Ware:

Attached is a patch that prevents mentioning Perl in the Windows build output, thereby avoiding giving the indication that Perl is necessary to build Python.

To make this work, the patch converts PCbuild/build_ssl.py into PCbuild/prepare_ssl.py and removes the actual building of OpenSSL from that script.  Instead, prepare_ssl.py takes a directory name as an argument (which is assumed to be a directory containing OpenSSL sources) and does what it has always done to prepare the way for building, except now it does it for both platforms.  PCbuild/build_ssl.bat is also updated to match.

Meanwhile, the actual building is moved entirely within ssl.vcxproj, which now runs a short script that copies buildinf*.h and opensslconf*.h into place and calls nmake with the appropriate makefile (x64 builds also run the appropriate nasm command first).  Since this is all done inside ssl.vcxproj, the dependency on python.vcxproj is dropped, allowing SSL to be built in parallel with pythoncore, tcl, tk, and tix when using the '/m' msbuild command line switch.

As a part of converting build_ssl.py into prepare_ssl.py, the comments at the top of the file have been updated.  Also, some dead code has been trimmed: the "-a" flag has been completely unused for a long time, and debug builds have been disabled as well; all code relating to either feature has been removed.

I've tested this by successfully preparing (once) and building openssl-1.0.1f in both 32 and 64 bit builds.

----------
components: Build, Windows
files: no_perl.diff
keywords: patch
messages: 215421
nosy: loewis, terry.reedy, tim.golden, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: Don't mention Perl in Windows build output
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file34711/no_perl.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21141>
_______________________________________


More information about the New-bugs-announce mailing list