[New-bugs-announce] [issue18256] thread_pthread.h fixes for AIX

[David Edelsohn]

New submission from David Edelsohn:

Recent releases of AIX do not need to call pthread_init(). The function is provided in libpthread.a for backward compatibility, but not declared in any header. This patch adds a declaration, or it can be removed completely because AIX 4.x no longer is supported.

The patch also adds uses of "error" to two functions to silence warnings, in a similar manner to other functions in the file.

diff -r f6f70f1ab124 Python/thread_pthread.h
--- a/Python/thread_pthread.h   Mon Jun 17 22:02:14 2013 +0200
+++ b/Python/thread_pthread.h   Tue Jun 18 11:54:50 2013 -0700
@@ -170,6 +170,7 @@
 PyThread__init_thread(void)
 {
 #if defined(_AIX) && defined(__GNUC__)
+    extern void pthread_init(void);
     pthread_init();
 #endif
 }
@@ -444,6 +445,7 @@
     pthread_lock *thelock = (pthread_lock *)lock;
     int status, error = 0;
 
+    (void) error; /* silence unused-but-set-variable warning */
     dprintf(("PyThread_free_lock(%p) called\n", lock));
 
     /* some pthread-like implementations tie the mutex to the cond
@@ -530,6 +532,7 @@
     pthread_lock *thelock = (pthread_lock *)lock;
     int status, error = 0;
 
+    (void) error; /* silence unused-but-set-variable warning */
     dprintf(("PyThread_release_lock(%p) called\n", lock));
 
     status = pthread_mutex_lock( &thelock->mut );

----------
components: Build
messages: 191410
nosy: David.Edelsohn
priority: normal
severity: normal
status: open
title: thread_pthread.h fixes for AIX
type: compile error
versions: Python 3.3, Python 3.4, Python 3.5

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18256>
_______________________________________