[New-bugs-announce] [issue17202] Add .bat line to .hgeol

[Zachary Ware]

New submission from Zachary Ware:

Most times (though not all, for some reason) I try to use Doc\make.bat update, it fails with "The system cannot find the batch label specified - update" even though it is obviously there.  The reason for this appears to be the fact that the file uses UNIX line endings[1].  As a fix, I think it would make the most sense to add a "**.bat = CRLF" line to .hgeol.

The attached patch makes that change and includes the changes that that change entails.  The complete list of affected files is as follows:

Doc\make.bat
Lib\ctypes\macholib\fetch_macholib.bat
Lib\idlelib\idle.bat
Modules\_decimal\tests\runall.bat
PCbuild\build.bat
PCbuild\build_env.bat
PCbuild\build_pgo.bat
PCbuild\build_ssl.bat
PCbuild\env.bat
PCbuild\idle.bat
PCbuild\rt.bat
Tools\buildbot\build-amd64.bat
Tools\buildbot\build.bat
Tools\buildbot\buildmsi.bat
Tools\buildbot\clean-amd64.bat
Tools\buildbot\clean.bat
Tools\buildbot\external-amd64.bat
Tools\buildbot\external-common.bat
Tools\buildbot\external.bat
Tools\buildbot\test-amd64.bat
Tools\buildbot\test.bat
Tools\unicode\genwincodecs.bat

As far as I know, there is no reason to believe that the changes to line endings in these files would cause any change to behavior other than possibly avoid strange and random bugs in their execution, particularly in Doc\make.bat.

If we don't want to a blanket rule like this, I think we should at least add a rule for Doc\make.bat to convert it to CRLF line endings to avoid the bug with :update.

Thanks,

Zach

[1] http://stackoverflow.com/questions/232651/why-the-system-cannot-find-the-batch-label-specified-is-thrown-even-if-label-e/232674#232674

----------
components: Windows
files: batch_eol_fix.diff
keywords: patch
messages: 182077
nosy: brian.curtin, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Add .bat line to .hgeol
versions: Python 3.4
Added file: http://bugs.python.org/file29070/batch_eol_fix.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue17202>
_______________________________________