[New-bugs-announce] [issue18701] Remove outdated PY_VERSION_HEX checks

Serhiy Storchaka report at bugs.python.org
Sat Aug 10 12:21:53 CEST 2013


New submission from Serhiy Storchaka:

Here is a patch which removes PY_VERSION_HEX checks in Modules/_ctypes/_ctypes.c, Modules/_sre.c, Objects/stringlib/unicodedefs.h and removes the Modules/_sqlite/sqlitecompat.h file.

_sre.c checks support Python versions <2.2, <2.2 or <1.6 which doesn't made sense because the code overall uses Unicode object API available only in Python >=3.3.

unicodedefs.h contains code to support Python <3.0, but stringlib code can't be shared with Python <3.3.

_ctypes.c and sqlitecompat.h contain code to support Python <2.5 which is not supported version.

----------
assignee: serhiy.storchaka
components: Extension Modules, Interpreter Core
files: no_version_checks.patch
keywords: patch
messages: 194789
nosy: amaury.forgeotdarc, belopolsky, benjamin.peterson, ezio.melotti, ghaering, haypo, lemburg, meador.inge, pitrou, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Remove outdated PY_VERSION_HEX checks
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file31212/no_version_checks.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18701>
_______________________________________


More information about the New-bugs-announce mailing list