[New-bugs-announce] [issue15894] _PyImport_ReInitLock() doesn't check return value of PyThread_acquire_lock

[Christian Heimes]

New submission from Christian Heimes:

Coverity claims that the call to PyThread_acquire_lock with NOWAIT_LOCK can fail. It sounds plausible as you don't wait for the lock to succeed.

CID 486861: Unchecked return value (CHECKED_RETURN)At (3): Calling function "PyThread_acquire_lock(PyThread_type_lock, int)" without checking return value (as is done elsewhere 22 out of 23 times).
At (9): No check of the return value of "PyThread_acquire_lock(import_lock, 0)".
 205        PyThread_acquire_lock(import_lock, 0);
 206        /* XXX: can the previous line fail? */

By the way the code would be more readable with NOWAIT_LOCK instead of 0.

----------
assignee: brett.cannon
components: Interpreter Core
messages: 170141
nosy: brett.cannon, christian.heimes
priority: normal
severity: normal
status: open
title: _PyImport_ReInitLock() doesn't check return value of PyThread_acquire_lock
type: behavior
versions: Python 3.2, Python 3.3

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue15894>
_______________________________________