[New-bugs-announce] [issue15759] "make suspicious" doesn't display instructions in case of failure

[Ezio Melotti]

New submission from Ezio Melotti:

I was running "make suspicious" in Doc/ and this was the output after finding 3 suspicious markups:

 writing output... [ 52%] library/inspect
 WARNING: [library/inspect:437] ":int" found in ">>> def foo(a, *, b:int, **kwargs):"
 WARNING: [library/inspect:437] ":int" found in "'(a, *, b:int, **kwargs)'"
 WARNING: [library/inspect:437] ":int" found in "'b:int'"
 writing output... [100%] whatsnew/index
 build finished with problems, 3 warnings.
 make: *** [build] Error 1

After figuring out how to mark these as false positives and adding the relevant entries to susp-ignored.csv, I ran "make suspicious" again, and got this useful message at the end:

 writing output... [100%] whatsnew/index
 build succeeded.

 Suspicious check complete; look for any errors in the above output or in build/suspicious /suspicious.csv.  If all issues are false positives, append that file to tools/sphinxext/susp-ignored.csv.

The problem is that this message should be displayed when there are failures, but it's not.

Attached an attempt to fix the Makefile to avoid exiting in case of failures when the builder is "suspicious".  Given that I'm not really familiar with makefiles, it probably doesn't make much sense.

----------
assignee: docs at python
components: Documentation
files: issue15759.diff
keywords: patch
messages: 168842
nosy: docs at python, eric.araujo, ezio.melotti, georg.brandl
priority: normal
severity: normal
stage: patch review
status: open
title: "make suspicious" doesn't display instructions in case of failure
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file26956/issue15759.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue15759>
_______________________________________