[New-bugs-announce] [issue11110] Py_DECREF->Py_XDECREF in Module/_sqlite/module.c

[Brett Cannon]

New submission from Brett Cannon <brett at python.org>:

Pretty straight forward change, but could potentially cause a NULL pointer deref in a rare situation.

diff --git a/Modules/_sqlite/module.c b/Modules/_sqlite/module.c
--- a/Modules/_sqlite/module.c
+++ b/Modules/_sqlite/module.c
@@ -329,7 +329,7 @@
         (pysqlite_statement_setup_types() < 0) ||
         (pysqlite_prepare_protocol_setup_types() < 0)
        ) {
-        Py_DECREF(module);
+        Py_XDECREF(module);
         return NULL;
     }

----------
components: Extension Modules
files: fix_sqlite.diff
keywords: patch
messages: 127853
nosy: brett.cannon, georg.brandl
priority: release blocker
severity: normal
stage: commit review
status: open
title: Py_DECREF->Py_XDECREF in Module/_sqlite/module.c
versions: Python 3.2
Added file: http://bugs.python.org/file20670/fix_sqlite.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11110>
_______________________________________