[New-bugs-announce] [issue2296] [PATCH] Tcl/Tk 8.4.16 patches needed to get an x64 Windows build

[Trent Nelson]

New submission from Trent Nelson <tnelson at onresolve.com>:

Martin, I've attached two patches required in order to get Tcl/Tk 8.4.16
to successfully compile on Windows x64.  I haven't included the patch to
external-amd64.bat (and pcbuild/readme.txt with updated build
instructions) yet as I wanted to confirm how you apply updates to the
external/ branch such that the buildbots can pick it up as well.

Note that I also dropped a generic standalone sed.exe into
tk-8.4.16/win, which is required for reasons that I couldn't be bothered
digging into in makefile.vc.  You can grab it from
http://svn.onresolve.com/external/tags/tcl-8.4.18.1/win/sed.exe.

Also, wanted to query the role of 'COMPILERFLAGS=-DWINVER=0x0500' in
your recommended nmake flags; do we still need it?  I used the following
for x64 debug builds:

..\tcl8.4.16\win>nmake -f makefile.vc DEBUG=1 MACHINE=AMD64
INSTALLDIR=../../tcltk64 clean all install

And for tk:

..\tk8.4.16\win>nmake -f makefile.vc DEBUG=1 MACHINE=AMD64
TCLDIR=../../tcl8.4.16 INSTALLDIR=../../tcltk64 clean all install

Let me know how you want to deal with the tcl/tk patches and then we can
look at fixing external-amd64.bat and updating pcbuild/readme.txt.

----------
components: Tkinter
files: tk-8.4.16.patch
keywords: patch
messages: 63566
nosy: Trent.Nelson, loewis
severity: normal
status: open
title: [PATCH] Tcl/Tk 8.4.16 patches needed to get an x64 Windows build
versions: Python 2.6, Python 3.0
Added file: http://bugs.python.org/file9676/tk-8.4.16.patch

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue2296>
__________________________________