[Moin-user] Very slow page saving caused by notifications

[Steve McIntyre]

On Sat, Apr 28, 2012 at 11:26:51PM +0100, Steve McIntyre wrote:
>On Sat, Apr 28, 2012 at 11:54:50PM +0200, Thomas Waldmann wrote:
>>> >i had a quick look at the subscribed users caching patch and I suspect
>>> >that might not be the case there.
>>> 
>>> Hmmm. It seems to work fine for me in testing, but it's possible that
>>> testing hasn't exercised all paths yet. Any suggestions on where to
>>> check?
>>
>>Check for race conditions / multi-threading/processing issues. What
>>happens if 2 cache updates happen at about the same time?
>
>Hmmm, OK. I naively assumed that the cache layer might handle locking
>itself, that's a shame.

Apologies, misunderstood you last night when I wrote that. I have an
updated patch that I've just attached:

http://moinmo.in/MoinMoinBugs/GetSubscribersSlow?action=AttachFile&do=view&target=subscribercache.patch

which seems to work for me. What do you think?

-- 
Steve McIntyre, Cambridge, UK.                                steve at einval.com
< sladen> I actually stayed in a hotel and arrived to find a post-it
          note stuck to the mini-bar saying "Paul: This fridge and
          fittings are the correct way around and do not need altering"