plus CSS indent ("text-indent: 2em" or something) instead of ol/ul. ---------------------------------------------------------------------- Comment By: Steve McIntyre (steve_mcintyre) Date: 2002-11-28 20:27 Message: Logged In: YES user_id=658437 Found a little bug in the code - deeply nested section numbers would break things - I was seeing 6.1.1 going to 9 for the next top-level header. This new patch ties up with my other one - if you use #pragma section-numbers 2 or #pragma section-numbers offset then it will ignore the very top-level header when counting and generating the TOC See http://www.einval.com/steve/patches/moinmoin/toc.patch ---------------------------------------------------------------------- Comment By: Steve McIntyre (steve_mcintyre) Date: 2002-11-28 18:40 Message: Logged In: YES user_id=658437 Excellent - just what I was looking for. I'm currently playing with the output of the section numbers code to allow you to use a top-level section that doesn't affect the section numbers. In the example page you've posted, everything appears as 1.something, which seems a little odd. I'll post my patch shortly... ---------------------------------------------------------------------- Comment By: Simon Huggins (huggie) Date: 2002-11-28 13:20 Message: Logged In: YES user_id=1192 Of course I meant: http://the.earth.li/~huggie/cgi-bin/moin/WikiSandBox Doh. ---------------------------------------------------------------------- Comment By: Simon Huggins (huggie) Date: 2002-11-28 13:19 Message: Logged In: YES user_id=1192 It's because as you've noticed of the top-level section. I can't see a sensible way around that though. You can see an example (or test :)) that isn't just 1.something at http://the.earth.li/~huggie/cgi-bin/moin/WikiSandbox ---------------------------------------------------------------------- Comment By: Steve McIntyre (steve_mcintyre) Date: 2002-11-28 12:29 Message: Logged In: YES user_id=658437 Excellent - just what I was looking for. I'm currently playing with the output of the section numbers code to allow you to use a top-level section that doesn't affect the section numbers. In the example page you've posted, everything appears as 1.something, which seems a little odd. I'll post my patch shortly... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=644224&group_id=8482 From noreply at sourceforge.net Tue Dec 3 14:27:02 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Tue Dec 3 14:27:02 2002 Subject: [Moin-devel] [ moin-Patches-638372 ] username/password authentication w/ SHA Message-ID: Patches item #638372, was opened at 2002-11-14 13:44 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bernhard Rosenkraenzer (bero) >Assigned to: J?rgen Hermann (jhermann) Summary: username/password authentication w/ SHA Initial Comment: Hi, I've noticed the earlier user/password authentication patch posted here, and liked the idea (though not all aspects of the implementation). Here's a new patch (based on the older one) that - works with CVS of about a week ago (didn't try today's) - doesn't store plaintext passwords anymore (uses SHA hashes) ---------------------------------------------------------------------- Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-11-25 16:45 Message: Logged In: YES user_id=15538 I'm attaching an updated version of this patch, fixing 1 typo and 1 thing I overlooked when porting the old patch to current CVS (current.text -> _ in the user name already exists error message) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 From noreply at sourceforge.net Tue Dec 3 14:28:06 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Tue Dec 3 14:28:06 2002 Subject: [Moin-devel] [ moin-Bugs-633145 ] savedata(pagename='UserPreferences', Message-ID: Bugs item #633145, was opened at 2002-11-04 08:05 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=633145&group_id=8482 Category: None Group: None >Status: Closed >Resolution: Works For Me Priority: 5 Submitted By: Internet Discovery (idiscovery) Assigned to: J?rgen Hermann (jhermann) Summary: savedata(pagename='UserPreferences', Initial Comment: AttributeError: getvalue Python 1.5.2 /usr/bin/python A problem occurred while running a Python script. Here is the sequence of function calls leading up to the error, with the most recent (innermost) call first. The exception attributes are: args = ('getvalue',) in __getattr__(self=FieldStorage(None, None, [MiniFieldStorage('logi...ff', '1'), MiniFieldStorage('username', 'Mike')]), name='getvalue') /home/idiscovery/lib/python/MoinMoin/userform.py in savedata(pagename='UserPreferences', request=) 165 166 # try to get the (optional) preferred language 167 theuser.language = form.getvalue('language', '') theuser = , global language = undefined, form = FieldStorage(None, None, [MiniFieldStorage('logi...ff', '1'), MiniFieldStorage('username', 'Mike')]), global getvalue = undefined 168 169 # checkbox options /home/idiscovery/lib/python/MoinMoin/wikiaction.py in do_userform(pagename='UserPreferences', request=) 491 def do_userform(pagename, request): 492 from MoinMoin import userform 493 savemsg = userform.savedata(pagename, request) savemsg = undefined, userform = , global savedata = undefined, pagename = 'UserPreferences', request = 494 Page(pagename).send_page(request, msg=savemsg) 495 ---------------------------------------------------------------------- Comment By: J?rgen Hermann (jhermann) Date: 2002-11-05 19:49 Message: Logged In: YES user_id=39128 w/o an url (preferably a public one) causing this traceback, no fix possible. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=633145&group_id=8482 From noreply at sourceforge.net Tue Dec 3 14:29:05 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Tue Dec 3 14:29:05 2002 Subject: [Moin-devel] [ moin-Bugs-638803 ] utils/wikiext.py defect in line 57 Message-ID: Bugs item #638803, was opened at 2002-11-15 08:32 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=638803&group_id=8482 Category: None Group: None >Status: Closed >Resolution: Invalid Priority: 5 Submitted By: Dierk Hoeppner (dhoeppner) Assigned to: J?rgen Hermann (jhermann) Summary: utils/wikiext.py defect in line 57 Initial Comment: Moin, in this file line 57 only shows "!!!!!!!!" which gives a python error of course :-( greetings Dierk -- Dierk H?ppner Universit?tsbibliothek Hannover und Technische Informationsbibliothek (UB/TIB) EDV Welfengarten 1b D-30167 Hannover Tel.: 0511 / 762 - 4067, Fax: 0511 / 762 - 5881 http://www.tib.uni-hannover.de ---------------------------------------------------------------------- >Comment By: J?rgen Hermann (jhermann) Date: 2002-12-03 23:28 Message: Logged In: YES user_id=39128 (still) experimental code in an unused module ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=638803&group_id=8482 From noreply at sourceforge.net Wed Dec 4 07:20:06 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Wed Dec 4 07:20:06 2002 Subject: [Moin-devel] [ moin-Patches-638372 ] username/password authentication w/ SHA Message-ID: Patches item #638372, was opened at 2002-11-14 12:44 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bernhard Rosenkraenzer (bero) Assigned to: J?rgen Hermann (jhermann) Summary: username/password authentication w/ SHA Initial Comment: Hi, I've noticed the earlier user/password authentication patch posted here, and liked the idea (though not all aspects of the implementation). Here's a new patch (based on the older one) that - works with CVS of about a week ago (didn't try today's) - doesn't store plaintext passwords anymore (uses SHA hashes) ---------------------------------------------------------------------- >Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-12-04 15:19 Message: Logged In: YES user_id=15538 I'm attaching another new version: - Verified to work with today's CVS - Allows users to change passwords - Password repeat prompt when creating an account or changing passwords - shortens cookie expiration times - you typically don't want non-expiring cookies for authenticated accounts I'm not yet fully satisfied with the last part (cookie expiration time); this should be configurable (like Sourceforge's Remember Me checkbox, or maybe "if the user has set a password, expire soon; if the user uses just the ID cookie, don't expire") - but the rest of the patch should be ok. ---------------------------------------------------------------------- Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-11-25 15:45 Message: Logged In: YES user_id=15538 I'm attaching an updated version of this patch, fixing 1 typo and 1 thing I overlooked when porting the old patch to current CVS (current.text -> _ in the user name already exists error message) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 From noreply at sourceforge.net Wed Dec 4 08:32:01 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Wed Dec 4 08:32:01 2002 Subject: [Moin-devel] [ moin-Patches-638372 ] username/password authentication w/ SHA Message-ID: Patches item #638372, was opened at 2002-11-14 12:44 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bernhard Rosenkraenzer (bero) Assigned to: J?rgen Hermann (jhermann) Summary: username/password authentication w/ SHA Initial Comment: Hi, I've noticed the earlier user/password authentication patch posted here, and liked the idea (though not all aspects of the implementation). Here's a new patch (based on the older one) that - works with CVS of about a week ago (didn't try today's) - doesn't store plaintext passwords anymore (uses SHA hashes) ---------------------------------------------------------------------- >Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-12-04 16:31 Message: Logged In: YES user_id=15538 Attaching yet another new version, adding a Sourceforge-like Remember Me button determining the expiration time of the login cookie. ---------------------------------------------------------------------- Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-12-04 15:19 Message: Logged In: YES user_id=15538 I'm attaching another new version: - Verified to work with today's CVS - Allows users to change passwords - Password repeat prompt when creating an account or changing passwords - shortens cookie expiration times - you typically don't want non-expiring cookies for authenticated accounts I'm not yet fully satisfied with the last part (cookie expiration time); this should be configurable (like Sourceforge's Remember Me checkbox, or maybe "if the user has set a password, expire soon; if the user uses just the ID cookie, don't expire") - but the rest of the patch should be ok. ---------------------------------------------------------------------- Comment By: Bernhard Rosenkraenzer (bero) Date: 2002-11-25 15:45 Message: Logged In: YES user_id=15538 I'm attaching an updated version of this patch, fixing 1 typo and 1 thing I overlooked when porting the old patch to current CVS (current.text -> _ in the user name already exists error message) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=638372&group_id=8482 From noreply at sourceforge.net Wed Dec 4 15:53:04 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Wed Dec 4 15:53:04 2002 Subject: [Moin-devel] [ moin-Bugs-648695 ] Bug in wikiutil.py Message-ID: Bugs item #648695, was opened at 2002-12-05 00:52 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Lele Gaifax (lele) Assigned to: Nobody/Anonymous (nobody) Summary: Bug in wikiutil.py Initial Comment: In wikiutil.do_info, the call to attachment_info passes request.form instead of the request itselt. This is causing errors in the Info of any page. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 From noreply at sourceforge.net Wed Dec 4 16:06:01 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Wed Dec 4 16:06:01 2002 Subject: [Moin-devel] [ moin-Bugs-648695 ] Bug in wikiaction.py Message-ID: Bugs item #648695, was opened at 2002-12-05 00:52 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Lele Gaifax (lele) Assigned to: Nobody/Anonymous (nobody) >Summary: Bug in wikiaction.py Initial Comment: In wikiutil.do_info, the call to attachment_info passes request.form instead of the request itselt. This is causing errors in the Info of any page. ---------------------------------------------------------------------- >Comment By: Lele Gaifax (lele) Date: 2002-12-05 01:05 Message: Logged In: YES user_id=239493 It was in wikiaction.py, not wikiutil.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 From noreply at sourceforge.net Thu Dec 5 00:43:04 2002 From: noreply at sourceforge.net (noreply at sourceforge.net) Date: Thu Dec 5 00:43:04 2002 Subject: [Moin-devel] [ moin-Bugs-648695 ] Bug in wikiaction.py Message-ID: Bugs item #648695, was opened at 2002-12-05 00:52 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Lele Gaifax (lele) >Assigned to: J?rgen Hermann (jhermann) Summary: Bug in wikiaction.py Initial Comment: In wikiutil.do_info, the call to attachment_info passes request.form instead of the request itselt. This is causing errors in the Info of any page. ---------------------------------------------------------------------- Comment By: Lele Gaifax (lele) Date: 2002-12-05 01:05 Message: Logged In: YES user_id=239493 It was in wikiaction.py, not wikiutil.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=648695&group_id=8482 From crosseyedpenguin at yahoo.com Mon Dec 9 12:06:05 2002 From: crosseyedpenguin at yahoo.com (Roger Haase) Date: Mon Dec 9 12:06:05 2002 Subject: [Moin-devel] [patch]Page.py,wikiutil.py - title2 should override

after page trail Message-ID: <20021209200555.43027.qmail@web14309.mail.yahoo.com> I submitted this patch a while back with a bug in it. When you override "title2" in moin_config.py and have the "Show page trail" checked in UserPreferences, title2 overrides the

before the page trail, not the

after the page trail. The patch below moves the lines creating the page trail from Page.py to wikiutil.py and makes a few minor code changes. The horizontal rule preceeding the page trail is eliminated and "title2" will override the

following the page trail (if the option is checked). Per you comment on the SourceForge patch submission page, If you have interest, I will add this to your project patch list. Roger Haase Index: Page.py =================================================================== RCS file: /cvsroot/moin/MoinMoin/Page.py,v retrieving revision 1.134 diff -u -r1.134 Page.py --- Page.py 28 Nov 2002 19:50:21 -0000 1.134 +++ Page.py 9 Dec 2002 04:52:27 -0000 @@ -364,19 +364,19 @@ pagename=self.page_name, print_mode=print_mode, allow_doubleclick=1) - # page trail? - if not print_mode and user.current.valid: - user.current.addTrail(self.page_name) - trail = user.current.getTrail() - if trail and user.current.show_page_trail: - delim = '>' - if string.lower(config.charset) == 'iso-8859-1': - delim = '?' - print '%s %s %s

' % ( - string.join( - map(lambda p: Page(p).link_to(), trail[:-1]), - " %s " % delim), - delim, cgi.escape(trail[-1])) + ## # page trail? -- moved to wikiutil 2002-11-22 + ## if not print_mode and user.current.valid: + ## user.current.addTrail(self.page_name) + ## trail = user.current.getTrail() + ## if trail and user.current.show_page_trail: + ## delim = '>' + ## if string.lower(config.charset) == 'iso-8859-1': + ## delim = '?' + ## print '%s %s %s

' % ( + ## string.join( + ## map(lambda p: Page(p).link_to(), trail[:-1]), + ## " %s " % delim), + ## delim, cgi.escape(trail[-1])) # user-defined form preview? if pi_formtext: Index: wikiutil.py =================================================================== RCS file: /cvsroot/moin/MoinMoin/wikiutil.py,v retrieving revision 1.119 diff -u -r1.119 wikiutil.py --- wikiutil.py 5 Dec 2002 17:47:19 -0000 1.119 +++ wikiutil.py 9 Dec 2002 04:52:28 -0000 @@ -722,6 +722,22 @@ 'pagename': quoteWikiname(keywords['pagename'])} print '