[Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi

Mark Sapiro mark at msapiro.net
Mon Jan 22 23:20:15 EST 2018


I am not familiar with uwsgi, so I really don't understand what's going
on, but what I can tell you is between Mailman 2.1.24 and Mailman 2.1 25
There were no changes in Mailman/SecurityManager.py or
Mailman/Cgi/Auth.py which are the modules that have to do with logging
in and passwords. The only change in Mailman/Cgi/private.py changed a
getting the username and password from

        username = cgidata.getvalue('username', '')
    password = cgidata.getvalue('password', '')

to

        username = cgidata.getfirst('username', '')
    password = cgidata.getfirst('password', '')


There were similar changes amongst others in Mailman/Cgi/admin.py and Mailman/Cgi/admindb.py

In the above, cgidata is an instance of the Python standard library
cgi.FieldStorage class. See https://docs.python.org/2/library/cgi.html
#higher-level-interface - the difference is getvalue() can return a
string or a list depending of whether the post data contains a single or
multiple settings for the variable. getfirst always returns a single
value, never a list.

However, this all occurs in handling the CGI input passed to the invoked
process so it's hard to see how this would produce what you are seeing.
As far as output from the CGI is concerned, there should be no change at
all to that from 'private'. 'admin' and 'admindb' do have some changes
in CSS to support enhanced accessibility for visually impaired users,
but nothing else.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/1744739

Title:
  2.1.25 login based pages not working with uwsgi

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions


More information about the Mailman-coders mailing list