[Bug 558128] Re: remove 552 exception for SMTP perm/temp

Mark Sapiro mark at msapiro.net
Wed Nov 1 20:12:22 EDT 2017


You are correct about DELIVERY_RETRY_WAIT being ignored. It could be
implemented by changing line 33 of Mailman/Queue/RetryRunner.py from

    SLEEPTIME = mm_cfg.minutes(15)

to

    SLEEPTIME = mm_cfg.DELIVERY_RETRY_WAIT

however that doesn't explain why in your case the retries were
continuous as they should be only once in 15 minutes.

> Is the code perhaps supposed to set a message's "deliver_after" to
"time + DELIVERY_RETRY_WAIT" after a failure?

That would be another (and better) way to implement DELIVERY_RETRY_WAIT
and may be the intent of deliver_after as it currently isn't set
anywhere.

It would also avoid the possibility of too frequent retrying if somehow
the time.sleep call is interrupted.

I have opened https://bugs.launchpad.net/mailman/+bug/1729472 for the
issue of DELIVERY_RETRY_WAIT being ignored and I will fix that. I'm
marking this "won't fix" as I don't intend to change the treatment of
552, at least for now.

** Changed in: mailman
       Status: Triaged => Won't Fix

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/558128

Title:
  remove 552 exception for SMTP perm/temp

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/558128/+subscriptions


More information about the Mailman-coders mailing list