From 266758 at bugs.launchpad.net Tue Apr 2 01:09:16 2013 From: 266758 at bugs.launchpad.net (Barry Warsaw) Date: Mon, 01 Apr 2013 23:09:16 -0000 Subject: [Bug 266758] Re: cc rejects to admins References: <20080905194239.1806.95156.launchpad@forster.canonical.com> Message-ID: <20130401230916.8496.51000.launchpad@gac.canonical.com> ** Tags added: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266758 Title: cc rejects to admins To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266758/+subscriptions From ron at fial.com Tue Apr 2 23:10:23 2013 From: ron at fial.com (Ron Fial) Date: Tue, 02 Apr 2013 21:10:23 -0000 Subject: [Bug 266284] Re: Unsubscribed users continue to receive reminders References: <20080905193035.27052.15943.launchpad@forster.canonical.com> Message-ID: <20130402211023.8465.2374.malone@chaenomeles.canonical.com> Make sure you don't have a crontab you don't know about. Look for the file /etc/cron.d/mailman If it is there, it is running your archive, digest, reminder etc. tasks. This 'hidden' crontab caused a lot of 'duplicate membership reminders' problems for me, because it does not show up with crontab -l -u mailman after installing mailman. So I ran crontab -e -u mailman, manually entered a crontab for the mailman user, and wound up with duplicate crontabs, and duplicate membership reminders. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266284 Title: Unsubscribed users continue to receive reminders To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266284/+subscriptions From mark at msapiro.net Wed Apr 3 23:26:13 2013 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 03 Apr 2013 21:26:13 -0000 Subject: [Bug 1164160] [NEW] The admindb summaries of held subscriptions and unsubscriptions are unsorted. References: <20130403212613.8952.36950.malonedeb@gac.canonical.com> Message-ID: <20130403212613.8952.36950.malonedeb@gac.canonical.com> Public bug reported: There is code that intends to sort these lists by email address for display, but it doesn't work. ** Affects: mailman Importance: Low Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1164160 Title: The admindb summaries of held subscriptions and unsubscriptions are unsorted. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1164160/+subscriptions From 1164160 at bugs.launchpad.net Thu Apr 4 00:28:59 2013 From: 1164160 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Wed, 03 Apr 2013 22:28:59 -0000 Subject: [Bug 1164160] Re: The admindb summaries of held subscriptions and unsubscriptions are unsorted. References: <20130403212613.8952.36950.malonedeb@gac.canonical.com> Message-ID: <20130403222900.21168.5768.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1164160 Title: The admindb summaries of held subscriptions and unsubscriptions are unsorted. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1164160/+subscriptions From mark at msapiro.net Thu Apr 4 00:29:52 2013 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 03 Apr 2013 22:29:52 -0000 Subject: [Bug 1164160] Re: The admindb summaries of held subscriptions and unsubscriptions are unsorted. References: <20130403212613.8952.36950.malonedeb@gac.canonical.com> Message-ID: <20130403222953.8911.16814.launchpad@gac.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1164160 Title: The admindb summaries of held subscriptions and unsubscriptions are unsorted. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1164160/+subscriptions From p.launchpad at nwl.cc Fri Apr 5 15:07:02 2013 From: p.launchpad at nwl.cc (Phil Sutter) Date: Fri, 05 Apr 2013 13:07:02 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130405130702.11423.63155.malone@gac.canonical.com> Sadly not. Removing this assignment makes lighttpd handle these files statically, i.e. deliver them instead of executing them. For testing, I have replaced /usr/lib/mailman/cgi-bin/admin with some wrapper script which prints it's arguments, the environment and stdin first before executing the real 'admin'. Strangely, there's nothing suspicous there. Despite digging through the mailman and python cgi code for a while now, I have no idea where the added parameter comes from. Do you have any idea where to continue searching for the bug's source? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Fri Apr 5 18:50:10 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 05 Apr 2013 16:50:10 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130405165010.16711.30005.malone@chaenomeles.canonical.com> What exactly do you get if you save the attached 'printenv' to /usr/lib/mailman/cgi-bin/ and go to the appropriate URL? You probably have to add "/printenv" => "", to lighttpd's cgi.assign, or you could just temporarily replace a lesser used script like create or edithtml with this one. ** Attachment added: "Python environment printer" https://bugs.launchpad.net/mailman/+bug/1160647/+attachment/3623802/+files/printenv -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From macobo at ut.ee Fri Apr 5 21:50:26 2013 From: macobo at ut.ee (Karl-Aksel Puulmann) Date: Fri, 05 Apr 2013 19:50:26 -0000 Subject: [Merge] lp:~macobo/mailman/macobo-conf_sort_option into lp:mailman Message-ID: <20130405195025.12614.19549.launchpad@ackee.canonical.com> Karl-Aksel Puulmann has proposed merging lp:~macobo/mailman/macobo-conf_sort_option into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1162492 in GNU Mailman: "Add a sort option to the conf subcommand" https://bugs.launchpad.net/mailman/+bug/1162492 For more details, see: https://code.launchpad.net/~macobo/mailman/macobo-conf_sort_option/+merge/157469 Since the -s option is taken by --section, I decided to use -x instead (perhaps should be changed). When doing the changes, I didn't notice that David Soto had already made a branch to fix this issue. -- https://code.launchpad.net/~macobo/mailman/macobo-conf_sort_option/+merge/157469 Your team Mailman Coders is requested to review the proposed merge of lp:~macobo/mailman/macobo-conf_sort_option into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3109 bytes Desc: not available URL: From 1162492 at bugs.launchpad.net Fri Apr 5 21:46:46 2013 From: 1162492 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Fri, 05 Apr 2013 19:46:46 -0000 Subject: [Bug 1162492] Re: Add a sort option to the conf subcommand References: <20130331142324.20888.15427.malonedeb@wampee.canonical.com> Message-ID: <20130405194654.3964.39114.launchpad@ackee.canonical.com> ** Branch linked: lp:~macobo/mailman/macobo-conf_sort_option -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1162492 Title: Add a sort option to the conf subcommand To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1162492/+subscriptions From mgill25 at outlook.com Sat Apr 6 15:56:21 2013 From: mgill25 at outlook.com (Manish Gill) Date: Sat, 06 Apr 2013 13:56:21 -0000 Subject: [Merge] lp:~mgill25/postorius/postorius into lp:postorius Message-ID: <20130406135620.16255.13166.launchpad@ackee.canonical.com> Manish Gill has proposed merging lp:~mgill25/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~mgill25/postorius/postorius/+merge/157515 Patch for Bug #1004052. :) Please let me know if there's anything missing! -- https://code.launchpad.net/~mgill25/postorius/postorius/+merge/157515 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1762 bytes Desc: not available URL: From 982555 at bugs.launchpad.net Sat Apr 6 16:20:51 2013 From: 982555 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sat, 06 Apr 2013 14:20:51 -0000 Subject: [Bug 982555] Re: LMTP should reject unknown lists in RCPT-stage References: <20120415195106.5314.78050.malonedeb@gac.canonical.com> Message-ID: <20130406142110.32112.57933.launchpad@ackee.canonical.com> ** Branch linked: lp:~macobo/mailman/macobo-rcpt-stage-reject -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/982555 Title: LMTP should reject unknown lists in RCPT-stage To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/982555/+subscriptions From macobo at ut.ee Sat Apr 6 16:31:19 2013 From: macobo at ut.ee (Karl-Aksel Puulmann) Date: Sat, 06 Apr 2013 14:31:19 -0000 Subject: [Merge] lp:~macobo/mailman/macobo-rcpt-stage-reject into lp:mailman Message-ID: <20130406143119.28845.9048.launchpad@ackee.canonical.com> Karl-Aksel Puulmann has proposed merging lp:~macobo/mailman/macobo-rcpt-stage-reject into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #982555 in GNU Mailman: "LMTP should reject unknown lists in RCPT-stage" https://bugs.launchpad.net/mailman/+bug/982555 For more details, see: https://code.launchpad.net/~macobo/mailman/macobo-rcpt-stage-reject/+merge/157516 It probably needs a little more work before merging. Open questions: 1) Is the test naming okay? 2) Should the tests be done in a different way? I didn't find any other tests that used the mock library. 3) Should the mocking be done within the setUp stage? 4) If that's okay, should get_mocked_lmtp_channel be moved to tests/helpers.py? -- https://code.launchpad.net/~macobo/mailman/macobo-rcpt-stage-reject/+merge/157516 Your team Mailman Coders is requested to review the proposed merge of lp:~macobo/mailman/macobo-rcpt-stage-reject into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3310 bytes Desc: not available URL: From p.launchpad at nwl.cc Sat Apr 6 16:40:53 2013 From: p.launchpad at nwl.cc (Phil Sutter) Date: Sat, 06 Apr 2013 14:40:53 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130406144053.27664.63302.malone@soybean.canonical.com> I get this output: REDIRECT_STATUS: 200 SERVER_SOFTWARE: lighttpd/1.4.32 SCRIPT_NAME: /printenv REQUEST_METHOD: GET SERVER_PROTOCOL: HTTP/1.1 CONTENT_LENGTH: 0 HTTP_USER_AGENT: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 HTTP_CONNECTION: keep-alive SERVER_NAME: lists.nwl.cc REMOTE_PORT: 32968 SERVER_PORT: 80 SERVER_ADDR: :: DOCUMENT_ROOT: /usr/lib64/mailman/cgi-bin/ SCRIPT_FILENAME: /usr/lib64/mailman/cgi-bin/printenv HTTP_DNT: 1 HTTP_HOST: lists.nwl.cc REQUEST_URI: /printenv HTTP_ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 GATEWAY_INTERFACE: CGI/1.1 REMOTE_ADDR: ::ffff:95.89.182.210 HTTP_ACCEPT_LANGUAGE: de-de,de;q=0.8,en-us;q=0.5,en;q=0.3 HTTP_ACCEPT_ENCODING: gzip, deflate Stdin: CGI: FieldStorage(None, None, []) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From p.launchpad at nwl.cc Sat Apr 6 16:44:44 2013 From: p.launchpad at nwl.cc (Phil Sutter) Date: Sat, 06 Apr 2013 14:44:44 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130406144444.27458.73453.malone@soybean.canonical.com> Note that this is expected behaviour. After logging in for the admin interface, no error is reported. The request forgery check message appears only after having clicked one of the links in the page's top. I should probably try to insert debugging output somewhere there, searching for any differences. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Sat Apr 6 21:59:56 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 06 Apr 2013 19:59:56 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130406195956.10787.83359.malone@gac.canonical.com> Aaah... I missed that. Look at the source of the page in your browser. How do the hrefs differ from what you use to go there. They will probably be relative, and I'n not interested in that difference, but if you absolutize them and then go directly, do you see the problem? If it has to do with the url being admin/LIST/general rather than admin/LIST, what to you get from the rrintenv script if you invoke it with printenv/aaaa/bbbb? I suspect that the issue may be related to your alias_url "/" => "/usr/lib64/mailman/cgi-bin/" what if you insert "/admin" => "/usr/lib64/mailman/cgi-bin/admin" ? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From p.launchpad at nwl.cc Sun Apr 7 00:27:29 2013 From: p.launchpad at nwl.cc (Phil Sutter) Date: Sat, 06 Apr 2013 22:27:29 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130406222729.9100.62131.malone@wampee.canonical.com> These two tests do not make any difference to the symptom. Though I think I found the culprit, but first things first. The reason why no error message is displayed right after login is that the login process is itself a form submission, and those are working as initially stated. So the problem is not really "caused" by clicking one of the page top links, also indicated by a browser page refresh also showing the error message. I did in turn add the same debug output to admin.py itself, which did not show anything special other than that the FieldStorage constructor returned 'FieldStorage(None, None, [MiniFieldStorage('admin', '')])'. While looking at the class's implementation again, I noticed that sys.argv is parsed while constructing the internal list so I added 'sys.argv[1]' to my debugging statement -> bingo! This is what happens: - the cgi-wrapper 'cgi-bin/admin' calls 'scripts/driver' with the scriptname as first parameter (i.e. 'admin') - 'scripts/driver' then uses 'sys.argv[1]' to find out it has to call 'main()' in 'Cgi/admin.py', but leaves 'sys.argv' intact - 'Cgi/admin.py' then calls the FieldStorage constructor which finds data in 'sys.argv[1]' (the FieldStorage class blows my mind, so I didn't bother digging to the point where this actually turns into a request parameter value) Could this be a problem with python2.7 (default on my system) instead of python3? Since the 'printenv' code you suggested is also python2 syntax I guess this should be a working configuration, no? Just for the record: in 'scripts/driver', below line 94 which reads 'scriptname = sys.argv[1]' I added a new line: 'sys.argv[1] = ""' which indeed made the error message disappear. Didn't test full functionality though. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Sun Apr 7 02:14:03 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 00:14:03 -0000 Subject: [Bug 1165589] [NEW] Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Public bug reported: The Switchboard.finish() method logs an error when attempting to preserve or unlink the .bak file throws an EnvironmentError exception, but the actual error message from the exception isn't logged. This missing information can be quite helpful. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From 1165589 at bugs.launchpad.net Sun Apr 7 02:58:56 2013 From: 1165589 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 07 Apr 2013 00:58:56 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20130407005858.22285.4299.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From mark at msapiro.net Sun Apr 7 02:59:45 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 00:59:45 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20130407005947.27222.25615.launchpad@soybean.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From mark at msapiro.net Sun Apr 7 03:13:14 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 01:13:14 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewingadmin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> <20130406222729.9100.62131.malone@wampee.canonical.com> Message-ID: >The reason why no error message is displayed right after login is that >the login process is itself a form submission, and those are working as >initially stated. So the problem is not really "caused" by clicking one >of the page top links, also indicated by a browser page refresh also >showing the error message. OK, I didn't understand that the problem only didn't occur when coming from the login screen. I thought you were OK on the direct URL visit even if already logged in. But I guess not. >This is what happens: >- the cgi-wrapper 'cgi-bin/admin' calls 'scripts/driver' with the scriptname as first parameter (i.e. 'admin') >- 'scripts/driver' then uses 'sys.argv[1]' to find out it has to call 'main()' in 'Cgi/admin.py', but leaves 'sys.argv' intact >- 'Cgi/admin.py' then calls the FieldStorage constructor which finds data in 'sys.argv[1]' >(the FieldStorage class blows my mind, so I didn't bother digging to the point where this actually turns into a request parameter value) > >Could this be a problem with python2.7 (default on my system) instead of >python3? Since the 'printenv' code you suggested is also python2 syntax >I guess this should be a working configuration, no? AFIK, Mailman 2.1 has not been well tested if at all with Python 2.7. It definitely will not work with Python 3.x. This CGI has been well exercised with Pythons 2.1 through 2.6, I will investigate the possibility of a Python 2.7 issue. It's time I upgraded my test platforms and production server anyway ;) >Just for the record: in 'scripts/driver', below line 94 which reads >'scriptname = sys.argv[1]' I added a new line: 'sys.argv[1] = ""' which >indeed made the error message disappear. Didn't test full functionality >though. It should be OK if it works. Even better might be del sys.argv[1] -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Sun Apr 7 06:11:49 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 04:11:49 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewingadmin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> <20130406222729.9100.62131.malone@wampee.canonical.com> Message-ID: <5160F205.5040902@msapiro.net> > I will investigate the possibility of a Python 2.7 issue. It's time I > upgraded my test platforms and production server anyway ;) I'm running Mailman now with Python 2.7.4 and not seeing this issue. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Sun Apr 7 07:19:32 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 05:19:32 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130407051932.11363.53087.malone@gac.canonical.com> OK. I finally looked at the code in Python's cgi module. It adds sys.argv[1:] to the list of query parameters for a GET if and only if there is no QUERY_STRING in the environment. Apache provides an empty QUERY_STRING when the URL doesn't have one and lighttpd does not. This is a bug in lighttpd. RFC 3875 says: The server MUST set this variable; if the Script-URI does not include a query component, the QUERY_STRING MUST be defined as an empty string (""). I will consider defending against this bug by making scripts/driver drop all but the first item in sys.argv, but it is really a lighttpd bug, not a Mailman bug. Thanks for your help in identifying the underlying issue. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From 1160647 at bugs.launchpad.net Sun Apr 7 07:58:14 2013 From: 1160647 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 07 Apr 2013 05:58:14 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130407055815.22284.10923.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From mark at msapiro.net Sun Apr 7 07:59:36 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 07 Apr 2013 05:59:36 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130407055938.9059.33867.launchpad@wampee.canonical.com> ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: Incomplete => Fix Committed ** Changed in: mailman Milestone: None => 2.1.16 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From p.launchpad at nwl.cc Sun Apr 7 12:56:01 2013 From: p.launchpad at nwl.cc (Phil Sutter) Date: Sun, 07 Apr 2013 10:56:01 -0000 Subject: [Bug 1160647] Re: request forgery check displayed when only viewing admin pages References: <20130327001348.23944.14740.malonedeb@soybean.canonical.com> Message-ID: <20130407105601.11423.37656.malone@gac.canonical.com> Oh well. Quick google search turned up this: http://redmine.lighttpd.net/issues/1339 so, this is actually a known issue in lighttpd for over two years now. Mark, thanks a lot for your time and effort in analysing this problem. Not sure if I ever would have found this on my own. I will address lighttpd's maintainers regarding this issue, hopefully this will eventually get a real fix. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1160647 Title: request forgery check displayed when only viewing admin pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1160647/+subscriptions From 1165589 at bugs.launchpad.net Sun Apr 7 14:05:51 2013 From: 1165589 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 07 Apr 2013 12:05:51 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20130407120551.17058.55869.malone@chaenomeles.canonical.com> Added MM3 bug task as this would be nice to get into 3.x also. ** Tags added: mailman3 ** Also affects: mailman/2.1 Importance: Undecided Status: New ** Also affects: mailman/3.0 Importance: Medium Assignee: Mark Sapiro (msapiro) Status: Fix Committed ** Changed in: mailman/2.1 Status: New => Fix Committed ** Changed in: mailman/2.1 Importance: Undecided => Medium ** Changed in: mailman/2.1 Assignee: (unassigned) => Mark Sapiro (msapiro) ** Changed in: mailman/2.1 Milestone: None => 2.1.16 ** Changed in: mailman/3.0 Status: Fix Committed => Triaged ** Changed in: mailman/3.0 Importance: Medium => Low ** Changed in: mailman/3.0 Assignee: Mark Sapiro (msapiro) => (unassigned) ** Changed in: mailman/3.0 Milestone: 2.1.16 => None -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From noreply at launchpad.net Mon Apr 8 06:36:20 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Mon, 08 Apr 2013 04:36:20 -0000 Subject: [Merge] lp:~mgill25/postorius/postorius into lp:postorius In-Reply-To: <20130406135620.16255.13166.launchpad@ackee.canonical.com> Message-ID: <20130408043619.32460.72899.launchpad@ackee.canonical.com> The proposal to merge lp:~mgill25/postorius/postorius into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~mgill25/postorius/postorius/+merge/157515 -- https://code.launchpad.net/~mgill25/postorius/postorius/+merge/157515 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/postorius/postorius into lp:postorius. From terri at zone12.com Mon Apr 8 06:41:19 2013 From: terri at zone12.com (Terri) Date: Mon, 08 Apr 2013 04:41:19 -0000 Subject: [Merge] lp:~mgill25/postorius/postorius into lp:postorius In-Reply-To: <20130406135620.16255.13166.launchpad@ackee.canonical.com> Message-ID: <20130408044022.9752.82385.codereview@wampee.canonical.com> Review: Approve Looks good. We might want to clean up the templates so we don't have ifs all on one line eventually just for readability, but there didn't seem any point in being picky today, so I've merged the code. Thanks! -- https://code.launchpad.net/~mgill25/postorius/postorius/+merge/157515 Your team Mailman Coders is subscribed to branch lp:postorius. From aurelien at bompard.org Mon Apr 8 14:50:25 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 08 Apr 2013 12:50:25 -0000 Subject: [Bug 1130957] Re: Unicode errors in mailman3 References: <20130220231858.9018.27307.malonedeb@gac.canonical.com> Message-ID: <20130408125025.11746.63925.malone@gac.canonical.com> I'm still trying to figure out the unicode errors in the digest runner, but something happens that I don't understand. In the add_message method, around line 264, the msg.as_string() call returns an str instance, but the msg.as_string().split("\n\n") call returns a list of unicode instances. This makes no sense to me. Could it come from the unicode-related overrides in mailman.email.message ? Could it be a bug in the python interpreter ? I'm using python 2.7.3. I can't find a way to reproduce it outside mailman. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130957 Title: Unicode errors in mailman3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130957/+subscriptions From 937154 at bugs.launchpad.net Mon Apr 8 18:11:14 2013 From: 937154 at bugs.launchpad.net (Barry Warsaw) Date: Mon, 08 Apr 2013 16:11:14 -0000 Subject: [Bug 937154] Re: bin/disabled.py is nonfunctional References: <20120220184758.18960.44280.malonedeb@soybean.canonical.com> Message-ID: <20130408161114.27499.32585.malone@soybean.canonical.com> I'm removing the 'easy' tag because updating this script is wrapped up in work I'm doing on the bounce processing subsystem. ** Tags removed: easy -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/937154 Title: bin/disabled.py is nonfunctional To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/937154/+subscriptions From varunsharmalive at gmail.com Mon Apr 8 18:38:21 2013 From: varunsharmalive at gmail.com (Varun Sharma) Date: Mon, 08 Apr 2013 16:38:21 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius Message-ID: <20130408163820.8538.69368.launchpad@ackee.canonical.com> Varun Sharma has proposed merging lp:~sharmavarun/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 added profile settins to my settings -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is requested to review the proposed merge of lp:~sharmavarun/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 5210 bytes Desc: not available URL: From terri at zone12.com Mon Apr 8 20:21:21 2013 From: terri at zone12.com (Terri) Date: Mon, 08 Apr 2013 18:21:21 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130408163820.8538.69368.launchpad@ackee.canonical.com> Message-ID: <20130408182052.27499.34235.codereview@soybean.canonical.com> Review: Needs Fixing We've had quite the debate about where extra profile information (such as twitter handles) should be stored, but haven't yet come to agreement. Storing it all in mailman core, which never uses it, may be wasteful, but it's unclear whether it should go with postorius, hyperkitty, or an external "web meta-info" that both of them can use. Until we do that, this patch isn't going to be usable. We may in fact want to do the complete opposite in the short-term and remove any references to extra profile info from postorius. -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From mgill25 at outlook.com Tue Apr 9 19:18:21 2013 From: mgill25 at outlook.com (Manish Gill) Date: Tue, 09 Apr 2013 17:18:21 -0000 Subject: [Merge] lp:~mgill25/mailman/mailman into lp:mailman Message-ID: <20130409171820.29351.89295.launchpad@ackee.canonical.com> Manish Gill has proposed merging lp:~mgill25/mailman/mailman into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1166911 in GNU Mailman: "domain option for `bin/mailman lists` doesn't work as expected" https://bugs.launchpad.net/mailman/+bug/1166911 For more details, see: https://code.launchpad.net/~mgill25/mailman/mailman/+merge/157920 Fix for #1166911 -- https://code.launchpad.net/~mgill25/mailman/mailman/+merge/157920 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/mailman/mailman into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 568 bytes Desc: not available URL: From mgill25 at outlook.com Tue Apr 9 19:13:03 2013 From: mgill25 at outlook.com (Manish Gill) Date: Tue, 09 Apr 2013 17:13:03 -0000 Subject: [Bug 1166911] [NEW] domain option for `bin/mailman lists` doesn't work as expected References: <20130409171303.27875.70181.malonedeb@soybean.canonical.com> Message-ID: <20130409171303.27875.70181.malonedeb@soybean.canonical.com> Public bug reported: (mailman)? mailman bin/mailman lists --domain example.cc 4 matching mailing lists found: Test1 at mail.localhost mytest at example.cc test2 at mail.localhost test3 at mail.localhost For the above output, only mytest at example.cc should've been the output. ** Affects: mailman Importance: Undecided Status: New ** Tags: command-line-scripts easy mailman3 ** Branch linked: lp:~mgill25/mailman/mailman -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1166911 Title: domain option for `bin/mailman lists` doesn't work as expected To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1166911/+subscriptions From varunsharmalive at gmail.com Wed Apr 10 07:46:21 2013 From: varunsharmalive at gmail.com (Varun Sharma) Date: Wed, 10 Apr 2013 05:46:21 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130408182052.27499.34235.codereview@soybean.canonical.com> Message-ID: Hi, I got your point, i was trying to do some work on the project i am going to apply for gsoc 2013 (Better User Settings management). As you are saying that the issue of adding extra profile has been discussed earlier and has been postponed, so should i create another branch and remove all references to extra profile ? Thanks Varun Sharma On Mon, Apr 8, 2013 at 11:51 PM, Terri wrote: > Review: Needs Fixing > > We've had quite the debate about where extra profile information (such as > twitter handles) should be stored, but haven't yet come to agreement. > Storing it all in mailman core, which never uses it, may be wasteful, but > it's unclear whether it should go with postorius, hyperkitty, or an > external "web meta-info" that both of them can use. > > Until we do that, this patch isn't going to be usable. We may in fact > want to do the complete opposite in the short-term and remove any > references to extra profile info from postorius. > -- > https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 > You are the owner of lp:~sharmavarun/postorius/postorius. > -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From mgill25 at outlook.com Thu Apr 11 14:57:25 2013 From: mgill25 at outlook.com (Manish Gill) Date: Thu, 11 Apr 2013 12:57:25 -0000 Subject: [Merge] lp:~mgill25/mailman/branch2 into lp:mailman Message-ID: <20130411125721.25834.25957.launchpad@ackee.canonical.com> Manish Gill has proposed merging lp:~mgill25/mailman/branch2 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1165589 in GNU Mailman: "Switchboard fails to log the error message with some exceptions." https://bugs.launchpad.net/mailman/+bug/1165589 For more details, see: https://code.launchpad.net/~mgill25/mailman/branch2/+merge/158359 Bug #1165589 fix -- https://code.launchpad.net/~mgill25/mailman/branch2/+merge/158359 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/mailman/branch2 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 655 bytes Desc: not available URL: From mgill25 at outlook.com Thu Apr 11 14:48:42 2013 From: mgill25 at outlook.com (Manish Gill) Date: Thu, 11 Apr 2013 12:48:42 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20130411124843.16667.70832.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:~mgill25/mailman/branch2 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From aurelien at bompard.org Thu Apr 11 17:56:43 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Thu, 11 Apr 2013 15:56:43 -0000 Subject: [Bug 1130957] Re: Unicode errors in mailman3 References: <20130220231858.9018.27307.malonedeb@gac.canonical.com> Message-ID: <20130411155643.17181.11002.malone@chaenomeles.canonical.com> OK, thanks to Toshio, I *finally* know what's going on here. Because of the import of "unicode_literals" from __future__ at the top of the file, the call to .split("\n\n") is actually interpreted as .split(u"\n\n"), thus the result is a list of unicode strings, which of course can't be decoded further in the following lines. To keep string literals, the string should be prefixed with "b", here's the patch: === modified file 'src/mailman/runners/digest.py' --- src/mailman/runners/digest.py 2013-01-01 14:05:42 +0000 +++ src/mailman/runners/digest.py 2013-04-11 15:52:53 +0000 @@ -260,7 +260,7 @@ # Add the payload. If the decoded payload is empty, this may be a # multipart message. In that case, just stringify it. payload = msg.get_payload(decode=True) - payload = (payload if payload else msg.as_string().split('\n\n', 1)[1]) + payload = (payload if payload else msg.as_string().split(b'\n\n', 1)[1]) try: charset = msg.get_content_charset('us-ascii') payload = unicode(payload, charset, 'replace') That's one of the errors I reported in this but, I'll investigate the other one now. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130957 Title: Unicode errors in mailman3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130957/+subscriptions From terri at zone12.com Thu Apr 11 20:33:21 2013 From: terri at zone12.com (Terri) Date: Thu, 11 Apr 2013 18:33:21 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130408163820.8538.69368.launchpad@ackee.canonical.com> Message-ID: <20130411183223.27458.69756.codereview@soybean.canonical.com> The better user settings management refers to managing the existing list settings, not adding new ones at this stage (although maybe later on in the summer that would be an option). If you're trying to get a leg up on that project, you should take a look at how these existing settings work. They're actually pretty complex: user preferences can be set per user, per email address, per list, per list&email address, etc. Look at the settings and how they're applied in Mailman 3 -- right now postorius has nothing that manages these in a useful way (but it does a bunch of experimental code I played with at pycon and checked in for my own reference -- to be honest, that code is more likely to be confusing than useful at this stage). -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From terri at zone12.com Thu Apr 11 20:37:22 2013 From: terri at zone12.com (Terri) Date: Thu, 11 Apr 2013 18:37:22 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130408163820.8538.69368.launchpad@ackee.canonical.com> Message-ID: <20130411183627.27374.20080.codereview@soybean.canonical.com> And by settings I mean things like "get this list in digest form" or "do not get mail delivery to this address" and "conceal yourself from the subscriber list?" -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From varunsharmalive at gmail.com Fri Apr 12 14:46:32 2013 From: varunsharmalive at gmail.com (Varun Sharma) Date: Fri, 12 Apr 2013 12:46:32 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130411183627.27374.20080.codereview@soybean.canonical.com> Message-ID: Hi, Right now i'm having some issues in postfix, i'll work on improvement of existing settings as soon as those issues gets fixed. I tried to add few other changes as my postfix thing was not working properly, do you have any suggestions on setting up mail server ? Thanks Varun Sharma On Fri, Apr 12, 2013 at 12:07 AM, Terri wrote: > And by settings I mean things like "get this list in digest form" or "do > not get mail delivery to this address" and "conceal yourself from the > subscriber list?" > -- > https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 > You are the owner of lp:~sharmavarun/postorius/postorius. > -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From aurelien at bompard.org Fri Apr 12 18:58:09 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Fri, 12 Apr 2013 16:58:09 -0000 Subject: [Bug 1130957] Re: Unicode errors in mailman3 References: <20130220231858.9018.27307.malonedeb@gac.canonical.com> Message-ID: <20130412165809.22307.72573.malone@wampee.canonical.com> OK, I found out where the second error comes from. When there is no administrator available, the message is sent to the site_owner from the configuration file, but this entry is not converted to unicode before being set in the msgdata dict. Thus, when it's added to the database, Storm refuses it. The following patch fixes this bug: === modified file 'src/mailman/handlers/owner_recipients.py' --- src/mailman/handlers/owner_recipients.py 2013-01-01 14:05:42 +0000 +++ src/mailman/handlers/owner_recipients.py 2013-04-12 16:47:29 +0000 @@ -55,7 +55,7 @@ # To prevent -owner messages from going into a black hole, if there # are no administrators available, the message goes to the site owner. if len(recipients) == 0: - msgdata['recipients'] = set((config.mailman.site_owner,)) + msgdata['recipients'] = set((unicode(config.mailman.site_owner),)) else: msgdata['recipients'] = recipients # Don't decorate these messages with the header/footers. Eventually -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130957 Title: Unicode errors in mailman3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130957/+subscriptions From terri at zone12.com Fri Apr 12 18:51:41 2013 From: terri at zone12.com (Terri) Date: Fri, 12 Apr 2013 16:51:41 -0000 Subject: [Merge] lp:~sharmavarun/postorius/postorius into lp:postorius In-Reply-To: <20130408163820.8538.69368.launchpad@ackee.canonical.com> Message-ID: <20130412165052.20100.48261.codereview@gac.canonical.com> You should email all further questions to the mailman-developers at python.org mailing list -- this merge request isn't really the place to sort out postfix questions. -- https://code.launchpad.net/~sharmavarun/postorius/postorius/+merge/157694 Your team Mailman Coders is subscribed to branch lp:postorius. From mgill25 at outlook.com Thu Apr 18 11:40:03 2013 From: mgill25 at outlook.com (Manish Gill) Date: Thu, 18 Apr 2013 09:40:03 -0000 Subject: [Bug 1166911] Re: domain option for `bin/mailman lists` doesn't work as expected References: <20130409171303.27875.70181.malonedeb@soybean.canonical.com> Message-ID: <20130418094003.6399.84268.launchpad@soybean.canonical.com> ** Description changed: (mailman)? mailman bin/mailman lists --domain example.cc 4 matching mailing lists found: Test1 at mail.localhost - mytest at example.cc + mytest at example.cc test2 at mail.localhost test3 at mail.localhost - For the above output, only mytest at example.cc should've been the output. + For the above, only mytest at example.cc should've been the output. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1166911 Title: domain option for `bin/mailman lists` doesn't work as expected To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1166911/+subscriptions From aurelien at bompard.org Thu Apr 18 15:18:12 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Thu, 18 Apr 2013 13:18:12 -0000 Subject: [Bug 1170347] [NEW] Digest handler crashes on non-ascii messages with no encoding header References: <20130418131812.25519.41384.malonedeb@chaenomeles.canonical.com> Message-ID: <20130418131812.25519.41384.malonedeb@chaenomeles.canonical.com> Public bug reported: I found an interesting bug in the to_digest handler: when a message is not ascii only but has no encoding defined (which happens in the wild unfortunately), the mailbox will crash when adding the message on line 58 of handlers/to_digest.py. The reason is that due to the mailman-specific email.message.Message modifications, some of the headers are unicode strings. As a consequence, when the mailbox.add code from the standard library serializes the email, it merges unicode strings with bytestrings, which result in an unicode string. If this string contains non-ascii characters, python will raise an UnicodeDecodeError doing so. The solution for that is to call the as_string() method before adding to the mailbox, it will do the serialization properly. I'm attaching the fix (one-liner) and a testcase to reproduce it (much larger). ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Patch added: "mailman-digestunicode.patch" https://bugs.launchpad.net/bugs/1170347/+attachment/3647526/+files/mailman-digestunicode.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170347 Title: Digest handler crashes on non-ascii messages with no encoding header To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170347/+subscriptions From aurelien at bompard.org Thu Apr 18 15:39:28 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Thu, 18 Apr 2013 13:39:28 -0000 Subject: [Bug 1170347] Re: Digest handler crashes on non-ascii messages with no encoding header References: <20130418131812.25519.41384.malonedeb@chaenomeles.canonical.com> Message-ID: <20130418133928.6832.23453.malone@soybean.canonical.com> Oops there was a typo in my patch, sorry about that. Here's the new one ** Patch added: "mailman-digestunicode.patch" https://bugs.launchpad.net/mailman/+bug/1170347/+attachment/3647541/+files/mailman-digestunicode.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170347 Title: Digest handler crashes on non-ascii messages with no encoding header To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170347/+subscriptions From steveth45 at gmail.com Thu Apr 18 17:16:35 2013 From: steveth45 at gmail.com (Stephen A. Goss) Date: Thu, 18 Apr 2013 15:16:35 -0000 Subject: [Bug 1170388] [NEW] the tomoderators argument to "send" is ignored References: <20130418151635.27701.73914.malonedeb@wampee.canonical.com> Message-ID: <20130418151635.27701.73914.malonedeb@wampee.canonical.com> Public bug reported: searching all the code (mailman-3.0.0b3) (with ack) for "tomoderators" returns this: $ ack -ai tomoderators src/mailman/bin/checkdbs.py 202: msg.send(mlist, **{'tomoderators': True}) src/mailman/chains/hold.py 241: nmsg.send(mlist, **dict(tomoderators=True)) src/mailman/app/moderator.py 228: msg.send(mlist, tomoderators=True) 299: msg.send(mlist, tomoderators=True) I can't see where this option is actually used. In practice, the moderation notification sent from hold.py in line 241 just goes to everyone in the mailing list, not the moderators. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170388 Title: the tomoderators argument to "send" is ignored To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170388/+subscriptions From steveth45 at gmail.com Thu Apr 18 19:13:55 2013 From: steveth45 at gmail.com (Stephen A. Goss) Date: Thu, 18 Apr 2013 17:13:55 -0000 Subject: [Bug 1170388] Re: the tomoderators argument to "send" is ignored References: <20130418151635.27701.73914.malonedeb@wampee.canonical.com> Message-ID: <20130418171355.27937.270.malone@wampee.canonical.com> I'm on a slightly older version of Mailman 3, which means that mail sent to list owner gets sent to entire list. It looks like *that* was already fixed, so I think in the current version, moderation notifications will probably actually get sent to list owner (should be sent to moderators). This is of course, still wrong. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170388 Title: the tomoderators argument to "send" is ignored To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170388/+subscriptions From steveth45 at gmail.com Thu Apr 18 20:04:40 2013 From: steveth45 at gmail.com (Stephen A. Goss) Date: Thu, 18 Apr 2013 18:04:40 -0000 Subject: [Bug 1170388] Re: the tomoderators argument to "send" is ignored References: <20130418151635.27701.73914.malonedeb@wampee.canonical.com> Message-ID: <20130418180441.25558.35274.launchpad@chaenomeles.canonical.com> ** Description changed: - searching all the code (mailman-3.0.0b3) (with ack) for "tomoderators" returns this: - - $ ack -ai tomoderators - src/mailman/bin/checkdbs.py - 202: msg.send(mlist, **{'tomoderators': True}) + searching all the code (mailman-3.0.0b3) (with ack) for "tomoderators" + returns this: - src/mailman/chains/hold.py - 241: nmsg.send(mlist, **dict(tomoderators=True)) + ?$ ack -ai tomoderators + ?src/mailman/bin/checkdbs.py + ?202: msg.send(mlist, **{'tomoderators': True}) - src/mailman/app/moderator.py - 228: msg.send(mlist, tomoderators=True) - 299: msg.send(mlist, tomoderators=True) + ?src/mailman/chains/hold.py + ?241: nmsg.send(mlist, **dict(tomoderators=True)) + + ?src/mailman/app/moderator.py + ?228: msg.send(mlist, tomoderators=True) + ?299: msg.send(mlist, tomoderators=True) I can't see where this option is actually used. In practice, the - moderation notification sent from hold.py in line 241 just goes to - everyone in the mailing list, not the moderators. + moderation notification sent from hold.py in line 241 just goes to the + list owner, not the moderators. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170388 Title: the tomoderators argument to "send" is ignored To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170388/+subscriptions From 1170726 at bugs.launchpad.net Fri Apr 19 16:35:37 2013 From: 1170726 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 19 Apr 2013 14:35:37 -0000 Subject: [Bug 1170726] [NEW] The LMTP server needs to check acceptable aliases References: <20130419143538.25347.27684.malonedeb@chaenomeles.canonical.com> Message-ID: <20130419143538.25347.27684.malonedeb@chaenomeles.canonical.com> Public bug reported: The LMTP server currently does a sanity check on the To field of the incoming message, to ensure that it is addressed to a valid mailing list. This check ignores acceptable aliases, but it should honor them. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170726 Title: The LMTP server needs to check acceptable aliases To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170726/+subscriptions From mark at msapiro.net Sat Apr 20 17:37:39 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 20 Apr 2013 15:37:39 -0000 Subject: [Bug 1170966] [NEW] HyperArch.py throws IndexError: string index out of range References: <20130420153739.26616.30291.malonedeb@gac.canonical.com> Message-ID: <20130420153739.26616.30291.malonedeb@gac.canonical.com> Public bug reported: There is code in Mailman/Archiver/HyperArch.py which gets the character set of a message in order to convert it if necessary to the character set of the archive. The code is charset = message.get_content_charset(cset_out) if charset: charset = charset.lower().strip() if charset[0]=='"' and charset[-1]=='"': charset = charset[1:-1] if charset[0]=="'" and charset[-1]=="'": charset = charset[1:-1] This code can throw an IndexError if get_content_charset() returns a non-null string containing only white space, e.g. a single new-line. It has been reported that this occurs resulting in tracebacks which end with something like File "Mailman/Archiver/HyperArch.py", line 311, in __init__ if charset[0]=='"' and charset[-1]=='"': IndexError: string index out of range The obvious, 'simple' fix for this is to change if charset: to if charset and charset.strip(): which will avoid the exception, but I really want to see an actual message that triggers this error as a test case for this and future changes. Unfortunately, despite trying with multiple versions of the Python email package, the only way I can get get_content_charset() to return a whitespace only result is with a header like Content-Type: text/plain; charset=" " which seems a bit too contrived to actually occur in the wild. Thus, if anyone can provide an actual message that triggers this exception, please attach it here. ** Affects: mailman Importance: Undecided Assignee: Mark Sapiro (msapiro) Status: Incomplete ** Changed in: mailman Status: New => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170966 Title: HyperArch.py throws IndexError: string index out of range To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170966/+subscriptions From aurelien at bompard.org Mon Apr 22 15:55:51 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 22 Apr 2013 13:55:51 -0000 Subject: [Bug 1091586] Re: Frequent OperationalError: database is locked with sqlite References: <20121218093500.12946.57302.malonedeb@wampee.canonical.com> Message-ID: <20130422135551.25223.34769.malone@chaenomeles.canonical.com> I'm still seeing a lot of those. Actually, by looking at the code, I can't find where such concurrent accesses are being prevented. Is it at all ? If not, that would explain the lock errors. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1091586 Title: Frequent OperationalError: database is locked with sqlite To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1091586/+subscriptions From iane at sussex.ac.uk Mon Apr 22 17:56:45 2013 From: iane at sussex.ac.uk (Ian Eiloart) Date: Mon, 22 Apr 2013 15:56:45 -0000 Subject: [Bug 1170726] Re: The LMTP server needs to check acceptable aliases References: <20130419143538.25347.27684.malonedeb@chaenomeles.canonical.com> Message-ID: <20130422155645.26718.86738.malone@gac.canonical.com> Does "the To field of the incoming message" mean the RCPT TO argument of the LMTP session? Or the "To:" header of the message. I think it should mean the former, since the latter needn't be related at all, if the list permits BCC. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170726 Title: The LMTP server needs to check acceptable aliases To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170726/+subscriptions From mark at msapiro.net Mon Apr 22 19:26:56 2013 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 22 Apr 2013 17:26:56 -0000 Subject: [Bug 1170726] Re: The LMTP server needs to check acceptable aliases References: <20130419143538.25347.27684.malonedeb@chaenomeles.canonical.com> Message-ID: <20130422172656.25585.20874.malone@chaenomeles.canonical.com> BCC is the whole point of this bug. If a list requires 'explicit destination', the list address or an acceptable alias must be in the To: or Cc: headers of the message. The bug says acceptable aliases aren't checked and it means against the To: or Cc: headers. Checking against the envelope recipient is irrelevant since if the list weren't the envelope recipient of the message, the list's chain wouldn't be seeing the message in the first place. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170726 Title: The LMTP server needs to check acceptable aliases To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170726/+subscriptions