[Bug 1031391] [NEW] remove msgdata['received_time'] in mailman.app.moderator before calling IListRequests.hold_request

Robert Niederreiter rnix at squarewave.at
Tue Jul 31 17:20:43 CEST 2012


Public bug reported:

msgdata['received_time'] in mailman.app.moderator.hold_message contains
datetime.datetime object when being called.

this causes hold_request to fail -> it expects only strings as
additional data.

so either remove received_time like so:

http://bazaar.launchpad.net/~rnix/mailman/anon-subscribe/revision/7159

before calling hold_request,

convert received_time to string before calling hold_request,

or improve mailman.model.request.ListRequests.hold_request as already
commented in source code (maybe to also accept datetime instances?)

cheers,

robert

** Affects: mailman
     Importance: Undecided
         Status: New

** Description changed:

  msgdata['received_time'] in mailman.app.moderator.hold_message contains
  datetime.datetime object when being called.
  
  this causes hold_request to fail -> it expects only strings as
  additional data.
  
  so either remove received_time like so:
  
  http://bazaar.launchpad.net/~rnix/mailman/anon-subscribe/revision/7159
  
  before calling hold_request,
  
  convert received_time to string before calling hold_request,
  
  or improve mailman.model.request.ListRequests.hold_request as already
- commented in source code
+ commented in source code (maybe to also accept datetime instances?)
  
  cheers,
  
  robert

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/1031391

Title:
  remove msgdata['received_time'] in mailman.app.moderator before
  calling IListRequests.hold_request

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/1031391/+subscriptions


More information about the Mailman-coders mailing list