[ mailman-Patches-1843966 ] newlist does not pass emailhost upon creation

[SourceForge.net]

Patches item #1843966, was opened at 2007-12-04 02:17
Message generated for change (Comment added) made by msapiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1843966&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: command line scripts
Group: Mailman 2.1
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Thijs Kinkhorst (kink)
Assigned to: Nobody/Anonymous (nobody)
Summary: newlist does not pass emailhost upon creation

Initial Comment:
Hi!

newlist does not pass emailhost to Create(), while that does support passing it, and actually uses it when passed too. In mlist.Create(), if emailhost==None, then it's
set to mm_cfg.DEFAULT_EMAIL_HOST which was probably not the intention of the list creator.

Attached patch fixes this issue. Please apply it, thanks!


Thijs

----------------------------------------------------------------------

>Comment By: Mark Sapiro (msapiro)
Date: 2007-12-04 10:59

Message:
Logged In: YES 
user_id=1123998
Originator: NO

It is true that newlist does not pass the email host name (actually
host_name, not emailhost at this point in the code) to Create(), but
immediately following a successful mlist.Create(), it does:

        # Assign domain-specific attributes
        mlist.host_name = host_name
        mlist.web_page_url = web_page_url

To set the list's host_name attribute.

The only thing Create() uses emailhost for is to append it to the listname
to make 'listname at emailhost' in order to determine that this is a valid
email address, but the intent of this is to validate the listname, not the
emailhost. Create() does not set any list attribute from emailhost.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1843966&group_id=103