[ mailman-Bugs-1471318 ] Missing Date header in "requires approval" attachment

[SourceForge.net]

Bugs item #1471318, was opened at 2006-04-16 08:22
Message generated for change (Comment added) made by msapiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1471318&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: mail delivery
Group: 2.1 (stable)
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Harri Porten (hporten)
Assigned to: Nobody/Anonymous (nobody)
Summary: Missing Date header in "requires approval" attachment

Initial Comment:
The message attachment part of the "xxx post from
xxx at xxx.xx requires approval" mails sent to the list
admin are lacking a Date header.

The part currently starts with

   Content-Type: message/rfc822
   MIME-Version: 1.0

while RFC822 mandates a Dates header to exist.

This is with version 2.1.5 compiled with sources on a
Debian 3.1 system. I've seen that the lack of the
header has been fixed for other types of mails but not
the attachment of this admin mail.

Harri.

----------------------------------------------------------------------

>Comment By: Mark Sapiro (msapiro)
Date: 2006-04-17 15:02

Message:
Logged In: YES 
user_id=1123998

Patch committed to subversion trunk.

----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro)
Date: 2006-04-17 14:37

Message:
Logged In: YES 
user_id=1123998

You are correct. The attached, Mailman generated "confirm"
message lacks a Date: header. This is wrong. The attached
patch against the 2.1.8 base should fix the problem. It will
be incorporated in the next release.

----------------------------------------------------------------------

Comment By: Harri Porten (hporten)
Date: 2006-04-17 12:06

Message:
Logged In: YES 
user_id=873548

Sorry. I just realized that I quoted the wrong set of
headers in my report. My MTA is apparantly complaining about
the lack of the Date header in the *last* part as generated
by Mailman:

--===============0382486014==
Content-Type: message/rfc822
MIME-Version: 1.0

Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: confirm eb636a7c7c9eff5aa0db306a3a2666d5baf486b0
Sender: test-request at example.com
From: test-request at example.com

If you reply to this message, keeping the Subject: header
intact,
Mailman will discard the held message.  Do this if the
message is
spam.  If you reply to this message and include an Approved:
header
with the list password in it, the message will be approved
for posting
to the list.  The Approved: header can also appear in the
first line
of the body of the reply.
--===============0382486014==--

Or does your answer apply to this part as well? I see that
RFC 1521 does indeed relax the 822 restrictions. Not sure
about the Date requirement, though.

----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro)
Date: 2006-04-16 08:50

Message:
Logged In: YES 
user_id=1123998

RFC822 and RFC2822 only address the top level message
headers. The standard for the headers of sub-parts in
multipart messages is RFC1521.

A Date header is not required in the headers of a sub-part.

If your issue is that the attached message/rfc822 part
itself contains no date header, this is an exact copy of the
message received by Mailman. It was up to whatever sent the
original message to include a Date: header.

If mailman receives a non-compliant message and holds it for
approval, it is not up to Mailman to try to correct defects
in the received message.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1471318&group_id=103