[Jython-checkins] jython: Fix mis-handling of the AS_ARRAY flag in BaseBuffer.hasArray

[jeff.allen]

https://hg.python.org/jython/rev/2aee2b3d18bf
changeset:   7939:2aee2b3d18bf
user:        Jeff Allen <ja.py at farowl.co.uk>
date:        Tue May 31 17:53:24 2016 +0100
summary:
  Fix mis-handling of the AS_ARRAY flag in BaseBuffer.hasArray

PyBufferTest will now run cleanly.

files:
  src/org/python/core/buffer/BaseBuffer.java |  4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/src/org/python/core/buffer/BaseBuffer.java b/src/org/python/core/buffer/BaseBuffer.java
--- a/src/org/python/core/buffer/BaseBuffer.java
+++ b/src/org/python/core/buffer/BaseBuffer.java
@@ -212,13 +212,13 @@
     @Override
     public boolean isReadonly() {
         // WRITABLE is a non-navigational flag, so is inverted in gFeatureFlags
-        return (gFeatureFlags & WRITABLE) != 0;
+        return (gFeatureFlags & WRITABLE) != 0; // i.e. featureFlags & WRITABLE is false
     }
 
     @Override
     public boolean hasArray() {
         // AS_ARRAY is a non-navigational flag, so is inverted in gFeatureFlags
-        return (gFeatureFlags & AS_ARRAY) != 0;
+        return (gFeatureFlags & AS_ARRAY) == 0; // i.e. featureFlags & AS_ARRAY is true
     }
 
     @Override

-- 
Repository URL: https://hg.python.org/jython