[Jython-checkins] jython (2.5): #1786: Properly close file handles in sys-package-mgr. Thanks Jeff Allen!

[Philip Jenvey]

On Dec 31, 2011, at 10:31 AM, frank.wierzbicki wrote:

> http://hg.python.org/jython/rev/958ecf3eb8f0
> changeset:   6291:958ecf3eb8f0
> branch:      2.5
> parent:      6289:68626d94a76d
> user:        Frank Wierzbicki <fwierzbicki at gmail.com>
> date:        Sat Dec 31 10:11:32 2011 -0800
> summary:
>  #1786: Properly close file handles in sys-package-mgr. Thanks Jeff Allen!
> 
> files:
>  src/org/python/core/packagecache/CachedJarsPackageManager.java |  1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/src/org/python/core/packagecache/CachedJarsPackageManager.java b/src/org/python/core/packagecache/CachedJarsPackageManager.java
> --- a/src/org/python/core/packagecache/CachedJarsPackageManager.java
> +++ b/src/org/python/core/packagecache/CachedJarsPackageManager.java
> @@ -317,6 +317,7 @@
>                 }
> 
>                 zipPackages = getZipPackages(jarin);
> +                jarin.close();
> 
>                 if (caching) {
>                     writeCacheFile(entry, jarcanon, zipPackages, brandNew);

This might as well be in a try/finally

--
Philip Jenvey