[Inpycon] Is PyCon India "really open"?

[Peeyush Aggarwal]

On 13-Jan-2018 12:56 AM, "vijay kumar" <vnbang2003 at gmail.com> wrote:



On Sat, Jan 13, 2018 at 12:45 AM, Peeyush Aggarwal <
peeyushaggarwal94 at gmail.com> wrote:

>
>
> On 13-Jan-2018 12:42 AM, "vijay kumar" <vnbang2003 at gmail.com> wrote:
>
>
>
> On Sat, Jan 13, 2018 at 12:33 AM, Shashank Kumar <
> shashankkumarkushwaha at gmail.com> wrote:
>
>> Hi again,
>>
>> On Saturday 13 January 2018 12:21 AM, vijay kumar wrote:
>>
>> Now that you says you didn't know anything, Are you correct to approve PR
>> ?
>> I Personally would not recommend anyone doing anyone.
>>
>>>
>>> Regards,
>>> Shashank Kumar
>>> @realslimshanky
>>>
>>
>>
>> --
>> Thanks,
>> Vijay
>>
>>
>> Sorry, if you are not getting me correctly but I stated here that my
>> review on github was solely based on the codebase and it's successful
>> deployment. Similarly, anyone should be able to review or comment since
>> both the options are available. I would strongly recommend there should be
>> a strict guideline for who can comment and review on which PR/Repository if
>> you feel otherwise.
>>
>
> You have approved the PR that not correct.  Please take a look on PR once
> again.
>
>
> Even I am not sure if the PR is correct or not.
>
Please when you not sure you should not approve PR.
I would personally recommend everyone not do this.


Thank you for the recommendation.




_______________________________________________
Inpycon mailing list
Inpycon at python.org
https://mail.python.org/mailman/listinfo/inpycon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/inpycon/attachments/20180113/0216dca2/attachment.html>