From taleinat at gmail.com Thu Jun 6 12:28:34 2019 From: taleinat at gmail.com (Tal Einat) Date: Thu, 6 Jun 2019 19:28:34 +0300 Subject: [Idle-dev] Feedback appreciated for two suggested new features In-Reply-To: References: Message-ID: After a great delay, I've created an issue[0] about the search dialogs being hidden behind the main window, and have a PR[1] up with a proposed fix. [0] https://bugs.python.org/issue37177 [1] https://github.com/python/cpython/pull/13869 On Thu, Oct 18, 2018 at 8:13 PM Irv Kalb wrote: > Hi, > > I don't have a strong opinion about the details of the search and replace > dialogs. However, I can tell you that a change replacing the dialog box > would be greatly appreciated. > > I teach Python classes using IDLE. The search dialog is a real a problem > for new students and me as the teacher. My students and I often get into a > scenario where the search dialog gets hidden behind a editing window. When > that happens, then you try to make edits in code and nothing happens. This > happens to very often. I have learned to look for the hidden search dialog > window, but my students get very flustered. > > I think that a search bar would be a great improvement. If you can model > it similar to the one in PyCharm, that would be wonderful. > > Thanks for looking into this issue. > > Irv > > > On Oct 13, 2018, at 2:51 PM, Tal Einat wrote: > > Hi, > > I've recently been working on two new features, for which I'd like to > discuss whether it would be wise to include in IDLE. Each has a working > implementation in a PR to make it easy to give it a try. > > 1. Replace the search and replace dialogs with a search bar > https://bugs.python.org/issue34976 > https://github.com/python/cpython/pull/9855 > > 2. Ability to run 3rd party code checkers > https://bugs.python.org/issue21880 > https://github.com/python/cpython/pull/9802 > > Any thoughts would be greatly appreciated! > > - Tal Einat > _______________________________________________ > IDLE-dev mailing list > IDLE-dev at python.org > https://mail.python.org/mailman/listinfo/idle-dev > > > _______________________________________________ > IDLE-dev mailing list > IDLE-dev at python.org > https://mail.python.org/mailman/listinfo/idle-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From Irv at furrypants.com Fri Jun 7 13:09:28 2019 From: Irv at furrypants.com (Irv Kalb) Date: Fri, 7 Jun 2019 10:09:28 -0700 Subject: [Idle-dev] Bug 37177 - Search dialog bug on Mac In-Reply-To: Message-ID: <0AF83C13-B6F6-41DF-BD13-4F7E8E5BAB34@furrypants.com> [I'm not sure of the proper protocol here, I hope sending a message this way is OK.] Hi, I am writing about the potential fix to the Search Dialog box problem in IDLE that I reported a while back. I can see that there is a flurry of activity on this bug. I saw that there was a code change, but since I have never looked at IDLE source code, I really cannot comment on the fix. However, I did see comments that it might be difficult to reproduce, so I made a short video to clearly demonstrate the bug. (This is on IDLE/Python 3.6.1 Mac) You can see it here: http://www.youtube.com/watch?v=YWDsOEN8qsE I did not get a chance to test this out on Windows, but the bug is easily reproducible on a Mac. If the change is to leave the dialog box in front of the editing window, that would be be fine. But long term, if it is possible to incorporate a search bar like the one in PyCharm, that would be even better. Thanks for addressing the issue and I hope this video is helpful. Irv From taleinat at gmail.com Sat Jun 8 09:15:14 2019 From: taleinat at gmail.com (Tal Einat) Date: Sat, 8 Jun 2019 16:15:14 +0300 Subject: [Idle-dev] Bug 37177 - Search dialog bug on Mac In-Reply-To: <0AF83C13-B6F6-41DF-BD13-4F7E8E5BAB34@furrypants.com> References: <0AF83C13-B6F6-41DF-BD13-4F7E8E5BAB34@furrypants.com> Message-ID: Hi Irv, Thanks for the reproduction video! It certainly helped to clarify the issue that you were expriencing. I can reproduce similar behavior with Python vesrions 3.6.8 and 3.7.3 (from python.org). My recently merged fix for issue 37177 does indeed fix this issue; with it, the search dialogs can't be hidden behind their parent editor/shell windows. - Tal Einat On Fri, Jun 7, 2019 at 8:12 PM Irv Kalb wrote: > [I'm not sure of the proper protocol here, I hope sending a message this > way is OK.] > > Hi, > > I am writing about the potential fix to the Search Dialog box problem in > IDLE that I reported a while back. I can see that there is a flurry of > activity on this bug. I saw that there was a code change, but since I have > never looked at IDLE source code, I really cannot comment on the fix. > > However, I did see comments that it might be difficult to reproduce, so I > made a short video to clearly demonstrate the bug. (This is on IDLE/Python > 3.6.1 Mac) You can see it here: > > http://www.youtube.com/watch?v=YWDsOEN8qsE < > http://www.youtube.com/watch?v=YWDsOEN8qsE> > > I did not get a chance to test this out on Windows, but the bug is easily > reproducible on a Mac. > > If the change is to leave the dialog box in front of the editing window, > that would be be fine. But long term, if it is possible to incorporate a > search bar like the one in PyCharm, that would be even better. > > Thanks for addressing the issue and I hope this video is helpful. > > Irv > > _______________________________________________ > IDLE-dev mailing list > IDLE-dev at python.org > https://mail.python.org/mailman/listinfo/idle-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From taleinat at gmail.com Wed Jun 12 18:13:47 2019 From: taleinat at gmail.com (Tal Einat) Date: Thu, 13 Jun 2019 01:13:47 +0300 Subject: [Idle-dev] Line numbers in IDLE Message-ID: I've just done some work on the (long awaited!) addition of line numbers to IDLE, and have a working PR ready. If some of you could try it out and give some feedback, that would be very helpful! See bpo-17535 for details; the PR is GH-14030 . Note that this is only for Python 3. -------------- next part -------------- An HTML attachment was scrubbed... URL: