[Expat-checkins] expat/lib xmlparse.c,1.44,1.45

[Greg Stein]

On Thu, Jun 13, 2002 at 02:53:40PM -0400, Karl Waclawek wrote:
>...
> > The indentation is off here. It looks like your new line uses spaces (good!)
> > but the surrounding lines use tabs.
> > 
> > Any opinions on "detabifying" the source code? (that is: convert all tabs to
> > spaces, and state that the "style" is no-tabs)
> 
> Yes, I would like spaces only.
> 
> Btw, to be honest, I don't like this "reverse indentation" style
> just to make it fit into 80 character lines.

Me neither; I didn't know it was present in the Expat sources. Do you have a
pointer?

IMO, I'd be quite happy to toss anything like that. In fact, a big revamp to
make everything consistent would be quite nice.

One caution (and I guess this applies to untabifying): if people generate
patches against 1.95.3, then we won't be able to apply them to the source
code. Thus, it is usually safest to do big revamps right before a release
(when the patch queue has been emptied).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/