[Expat-bugs] [ expat-Bugs-1217217 ] Expat 1.95.8 does not obey $DESTDIR on install

[SourceForge.net]

Bugs item #1217217, was opened at 2005-06-08 16:12
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1217217&group_id=10127

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Expat 1.95.8 does not obey $DESTDIR on install

Initial Comment:
Submitted by mjbauer (at) rent-a-clue (dot) com

The Makefile.in in src/ in the build tree has no
references whatsoever to $DESTDIR or ${DESTDIR}.  The
environment variable is utterly ignored on make install
run against the generated Makefile.

I have edited Makefile.in to properly obey $DESTDIR;
below is a diff of the old and new versions.  Please
include a $DESTDIR-obeying Makefile.in in future releases.

> diff Makefile.in.old Makefile.in
76,78c76,78
<       $(mkinstalldirs) $(bindir) $(man1dir)
<       $(LIBTOOL) --mode=install $(INSTALL_PROGRAM)
xmlwf/xmlwf
$(bindir)/xmlwf
<       $(INSTALL_DATA) $(MANFILE) $(man1dir)
---
>       $(mkinstalldirs) ${DESTDIR}$(bindir)
${DESTDIR}$(man1dir)
>       $(LIBTOOL) --mode=install $(INSTALL_PROGRAM)
xmlwf/xmlwf
>       ${DESTDIR}$(bindir)/xmlwf
>       $(INSTALL_DATA) $(MANFILE) ${DESTDIR}$(man1dir)
81,83c81,83
<       $(mkinstalldirs) $(libdir) $(includedir)
<       $(LIBTOOL) --mode=install $(INSTALL) $(LIBRARY)
>       $(libdir)/$(LIBRARY)
<       $(INSTALL_DATA) $(APIHEADER) $(includedir)
---
>       $(mkinstalldirs) ${DESTDIR}$(libdir)
${DESTDIR}$(includedir)
>       $(LIBTOOL) --mode=install $(INSTALL) $(LIBRARY)
>       ${DESTDIR}$(libdir)/$(LIBRARY)
>       $(INSTALL_DATA) $(APIHEADER)
${DESTDIR}$(includedir)
86,87c86,87
<       $(LIBTOOL) --mode=uninstall rm -f $(bindir)/xmlwf
<       rm -f $(man1dir)/xmlwf.1
---
>       $(LIBTOOL) --mode=uninstall rm -f
${DESTDIR}$(bindir)/xmlwf
>       rm -f ${DESTDIR}$(man1dir)/xmlwf.1
90,91c90,91
<       $(LIBTOOL) --mode=uninstall rm -f
$(libdir)/$(LIBRARY)
<       rm -f $(includedir)/$(APIHEADER)
---
>       $(LIBTOOL) --mode=uninstall rm -f
>       ${DESTDIR}$(libdir)/$(LIBRARY)
>       rm -f ${DESTDIR}$(includedir)/$(APIHEADER)


----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2006-01-12 19:55

Message:
Logged In: YES 
user_id=290026

In Makefile.in rev. 1.48 this was added:

ifndef INSTALL_ROOT
INSTALL_ROOT=$(DESTDIR)
endif

and seems to work.

Closing issue.


----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2005-06-15 08:42

Message:
Logged In: YES 
user_id=290026

Fred,

you are better on make files. Assigned to you.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1217217&group_id=10127