[ expat-Patches-461763 ] BOM and ExternalSubset

Fri May 31 06:39:21 2002

Patches item #461763, was opened at 2001-09-15 00:36
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=461763&group_id=10127

Category: None
Group: None
Status: Open
Resolution: None
Priority: 6
Submitted By: Gilles Marichal (gilou)
Assigned to: Karl Waclawek (kwaclaw)
Summary: BOM and  ExternalSubset

Initial Comment:

Hello,
Expat parsing failed when the file to parse had an 
external subset starting with a BOM.
Adding the following two lines at the start of 
function externalSubset0 in xmlrole.c fixes the 
problem:

  if (tok == XML_TOK_BOM)
    return XML_ROLE_NONE;

Note: while correcting that problem, I looked in the 
xmlrole.c file the others parts of the code handling 
the XML_TOK_BOM token. I'd like to know the rationale 
for handling it in prolog1 (wouldn't it always be 
handled in prolog0 only?).

G. Marichal

----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2002-05-31 09:38

Message:
Logged In: YES 
user_id=290026

Looked at it.
It is the same problem as reported in bug # 551852.
Patch # 551599 deals with this problem in a more 
general way, i.e. including general external entities.
So when bug # 551852 is closed, we should close
this patch too.

Karl

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2002-05-31 00:12

Message:
Logged In: YES 
user_id=3066

Karl, can this be closed?  Do we need a test case?

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2002-05-09 21:26

Message:
Logged In: YES 
user_id=290026

It seems this is related to bug # 551852.
In this bug, as well as in patch #551599,
a fix has been proposed as well.

Karl

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=461763&group_id=10127