[docs] TimedRotatingFileHandler documentation regarding 'Week day' lacking (issue 17376)

tshepang at gmail.com tshepang at gmail.com
Thu Mar 7 18:56:08 CET 2013


Reviewers: ,


http://bugs.python.org/review/17376/diff/7548/Doc/library/logging.handlers.rst
File Doc/library/logging.handlers.rst (right):

http://bugs.python.org/review/17376/diff/7548/Doc/library/logging.handlers.rst#newcode320
Doc/library/logging.handlers.rst:320: | ``'W<number>'``| Week day
(0=Monday)   |
LGTM

http://bugs.python.org/review/17376/diff/7548/Doc/library/logging.handlers.rst#newcode326
Doc/library/logging.handlers.rst:326: ``W`` and the number of the day of
the week. Monday is 0, Sunday is 6.
I think it's enough to just change the text on the table. Should be
obvious... the explanation here is redundant.



Please review this at http://bugs.python.org/review/17376/

Affected files:
  Doc/library/logging.handlers.rst


diff -r 66d0f6ef2a7f Doc/library/logging.handlers.rst
--- a/Doc/library/logging.handlers.rst	Thu Feb 28 18:03:16 2013 +0200
+++ b/Doc/library/logging.handlers.rst	Thu Mar 07 09:51:33 2013 -0500
@@ -317,11 +317,14 @@
    +----------------+-----------------------+
    | ``'D'``        | Days                  |
    +----------------+-----------------------+
-   | ``'W'``        | Week day (0=Monday)   |
+   | ``'W<number>'``| Week day (0=Monday)   |
    +----------------+-----------------------+
    | ``'midnight'`` | Roll over at midnight |
    +----------------+-----------------------+
 
+   When using a rotation based on the day of the week from Monday to Sunday, use
+   ``W`` and the number of the day of the week. Monday is 0, Sunday is 6.
+
    The system will save old log files by appending extensions to the filename.
    The extensions are date-and-time based, using the strftime format
    ``%Y-%m-%d_%H-%M-%S`` or a leading portion thereof, depending on the




More information about the docs mailing list