[Cython] bytearray tests fail with default unsigned char

Stefan Behnel stefan_ml at behnel.de
Thu Jan 23 19:19:21 CET 2014


Julian Taylor, 22.01.2014 00:03:
> the bytearray tests are broken when chars are unsigned.
> 
> tests/run/bytearraymethods.pyx defines following function:
> def bytearray_append(b, char c, int i, object o):
> 
> this gets converted to an effective __Pyx_PyInt_AsUnsignedChar which
> then errors out when -1 is passed in.
> chars are unsigned like they are by default on arm, s390x and powerpc.
> This causes a couple build failures in debian:
> https://buildd.debian.org/status/package.php?p=cython
> https://buildd.debian.org/status/fetch.php?pkg=cython&arch=armel&ver=0.20-1&stamp=1390316252
> 
> the tests can be fixed by adding signed char to the interface.

Thanks for the report. You're right, testing with 'signed char' is better here.

https://github.com/cython/cython/commit/0b665f974669b7ad5c68c7fb3fcedad883c51426

Stefan



More information about the cython-devel mailing list