[Cython] Bindings performance issue

Vitja Makarov vitja.makarov at gmail.com
Tue Jun 21 09:34:11 CEST 2011


2011/6/21 Stefan Behnel <stefan_ml at behnel.de>:
> Vitja Makarov, 21.06.2011 09:07:
>>
>> 2011/6/21 Stefan Behnel:
>>>
>>> Vitja Makarov, 20.06.2011 22:23:
>>>>
>>>> Wow now we have about 11K tests with 171 errors!
>>>>
>>>>
>>>> https://sage.math.washington.edu:8091/hudson/view/cython-vitek/job/cython-vitek-tests-pyregr-py27-c/
>>>
>>> Yes, that was a low hanging, high value bug.
>>>
>>> """
>>> Make cyfunction __name__ attribute writable
>>> """
>>>
>>> Could you provide a pull request with that change?
>>
>> Do you mean single change or whole branch?
>
> Hmm, I didn't look at the other changes in the branch yet. Actually, I
> followed the link in Jenkins and the changeset page didn't even show me
> which branch it was. This one, I guess:
>
> https://github.com/vitek/cython/commits/_bindings
>
> I'll give it a review when I get to it.
>
> Do you think this branch is ready for a merge, or is there more to be done?
>

I think it's almost done. But it's better to review it because lots of
new C code there.
So I can create pull request to make code review easy.

-- 
vitja.


More information about the cython-devel mailing list