[C++-sig] Patch implementing void * support
David Abrahams
dave at boost-consulting.com
Thu Jan 26 18:08:20 CET 2006
David Abrahams <dave at boost-consulting.com> writes:
> David Abrahams <dave at boost-consulting.com> writes:
>
>> "Niall Douglas" <s_sourceforge at nedprod.com> writes:
>>
>>> On 24 Jan 2006 at 10:51, David Abrahams wrote:
>>>
>>>> All the ones you've posted come with disclaimers or corrections, such
>>>> as:
>>>>
>>>> I understand from Roman that I have too many typenames in there, but
>>>> other than this trivial fix the patch works perfectly on GCC.
>>>
>>> It was literally a case of removing some unnecessary typename
>>> keywords. It didn't take two seconds and at that time I didn't have
>>> access to Linux. I do now.
>>>
>>> Anyway, it's attached working on GCC 4.0.2 and MSVC 6.0 and 7.1.
>>
>> So these workarounds that are guarded by
>>
>> #ifdef BOOST_MSVC
>>
>> Are known to be needed on vc7.1 as well as vc6? What about vc8?
>> You ought to be using BOOST_WORKAROUND here.
>
> This really looks careless. As submitted the patch doesn't compile
> because there's a missing
>
> #include <boost/type_traits/broken_compiler_spec.hpp>
>
> in type_id.hpp
And even after I add that, it breaks compilation.
--
Dave Abrahams
Boost Consulting
www.boost-consulting.com
More information about the Cplusplus-sig
mailing list