[Borgbackup] bundling msgpack for borgback distribution
Thomas Waldmann
tw at waldmann-edv.de
Sun May 12 19:57:17 EDT 2019
>> Hmm, what's the problem with test_dash_open?
>
> I did not add the exclusion but the spec file has a comment:
> # exclude test_dash_open: pytest stub has a bug and is fixed in 3.0.2 (epel7
> uses 2.8.5)
>
> I think the spec file is shared between Fedora + CentOS 7 (= EPEL) and just
> excluding that test might make the spec simpler. (EPEL 7 now uses 2.9.2)
Ah, ok.
> Right now I see a hang in the test suite on Fedora's s390x builder:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=34754384
build/lib.linux-s390x-3.7/borg/testsuite/archiver.py::RemoteArchiverTestCase::test_extract_capabilities
SKIPPED [ 15%]
That is the last line in the log.
But as it says skipped, I suspect in hangs in the test afterwards.
> Jerry James mentioned that it hangs in
> RemoteArchiverTestCase::test_extract_hardlinks
> see also:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/SDBGO7IEEMFW3VHMOVZQ73RGISNOJ6CU/
If it is that, it will be fixed in borg 1.1.10.
Somehow this is a bug that only bit sometimes, just rerunning the test
can make it pass.
The real fix will be in 1.1.10, it was a problem when the master
hardlink content chunks did not get preloaded (because not selected for
extraction), but the (selected) slave hardlink expected it to be
preloaded...
> Most of that patch was merged by upstream today:
> https://github.com/msgpack/msgpack-python/pull/357
Cool. :)
I've made a PR from your patches and will try to have that in 1.1.10 also.
--
GPG ID: 9F88FB52FAF7B393
GPG FP: 6D5B EF9A DD20 7580 5747 B70F 9F88 FB52 FAF7 B393
More information about the Borgbackup
mailing list