[Borgbackup] 1.0.5 binary release fails to write to nas mounted repo

[Sitaram Chamarty]

Hi,

One of my backup scripts writes direct to a NAS drive mounted via CIFS.
I moved from 1.0.0 binary release to 1.0.5 binary release, and it no
longer works.

I'm attaching a file containing a full test from scratch; I'd be happy
to do more testing as needed, or open an issue if that is preferable.
(I did look to see if someone had already opened an issue for this
sometime between 1.0.0 and now, but I couldn't find any, offhand, by
searching for one of these strings: CIFS, NFS, NAS).

regards
sitaram
-------------- next part --------------
NOTE: /root/nas was mounted by a command like:
    mount -t cifs -o username=alice //1.2.3.4/some_volume_name nas

All commands run as root in this test.

----

# rm -rf foo nas/foo

# borg init -e none foo

# borg create -v --list foo::1 .bashrc .bash_history
A .bashrc
A .bash_history

# borg create -v --list foo::2 .bashrc .bash_history
U .bashrc
A .bash_history

# mv foo nas/
mv: preserving times for ‘nas/foo/data/0’: Permission denied
mv: failed to preserve ownership for ‘nas/foo/data/0’: Permission denied
mv: preserving permissions for ‘nas/foo/data/0’: Permission denied
mv: preserving times for ‘nas/foo/data’: Permission denied
mv: failed to preserve ownership for ‘nas/foo/data’: Permission denied
mv: preserving permissions for ‘nas/foo/data’: Permission denied
mv: preserving times for ‘nas/foo’: Permission denied
mv: failed to preserve ownership for ‘nas/foo’: Permission denied
mv: preserving permissions for ‘nas/foo’: Permission denied

# borg create -v --list nas/foo::3 .bashrc .bash_history
Warning: The repository at location /root/nas/foo was previously located at /root/foo
Do you want to continue? [yN] y
U .bashrc
A .bash_history
Exception ignored in: <bound method Repository.__del__ of <Repository /root/nas/foo>>
Traceback (most recent call last):
  File "borg/repository.py", line 72, in __del__
  File "borg/repository.py", line 189, in close
  File "borg/repository.py", line 532, in close
  File "borg/repository.py", line 752, in close_segment
ValueError: flush of closed file
Local Exception.
Traceback (most recent call last):
  File "borg/archiver.py", line 81, in wrapper
  File "borg/archiver.py", line 247, in do_create
  File "borg/archiver.py", line 221, in create_inner
  File "borg/archive.py", line 317, in save
  File "borg/repository.py", line 197, in commit
  File "borg/repository.py", line 746, in write_commit
  File "borg/repository.py", line 759, in close_segment
  File "borg/platform.py", line 9, in sync_dir
OSError: [Errno 22] Invalid argument

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "borg/archiver.py", line 1601, in main
  File "borg/archiver.py", line 1538, in run
  File "borg/archiver.py", line 81, in wrapper
  File "borg/repository.py", line 94, in __exit__
  File "borg/repository.py", line 189, in close
  File "borg/repository.py", line 532, in close
  File "borg/repository.py", line 752, in close_segment
ValueError: flush of closed file

Platform: Linux sita-wd.atc.tcs.com 4.1.8-100.fc21.x86_64 #1 SMP Tue Sep 22 12:13:06 UTC 2015 x86_64 x86_64
Linux: Fedora 21 Twenty One
Borg: 1.0.5  Python: CPython 3.5.2
PID: 22639  CWD: /root
sys.argv: ['borg', 'create', '-v', '--list', 'nas/foo::3', '.bashrc', '.bash_history']
SSH_ORIGINAL_COMMAND: None

rc: 2