➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2002-07-08 00:50 by vinay.sajip, last changed 2022-04-10 16:05 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| logging-0.4.6.tar.gz | vinay.sajip, 2002-07-08 00:50 | Entire distribution of logging module | ||
| logging.py | vinay.sajip, 2002-07-08 00:56 | The logging module itself (V0.4.6) | ||
| logging.tar.gz | vinay.sajip, 2002-10-16 09:24 | Refactored module as a package (interim release) | ||
| Messages (6) | |||
|---|---|---|---|
| msg40513 - (view) | Author: Vinay Sajip (vinay.sajip) *  |
Date: 2002-07-08 00:50 | |
The attached file implements PEP282. The file logging- 0.4.6.tar.gz is the entire distribution including setup/install, test/example scripts, and TeX documentation. The file logging.py (within the .tar.gz) is all that is needed to implement the PEP. |
|||
| msg40514 - (view) | Author: Vinay Sajip (vinay.sajip) * |
Date: 2002-07-08 00:56 | |
Logged In: YES user_id=308438 Added just the logging.py file to make it easier to review. |
|||
| msg40515 - (view) | Author: Mark Hammond (mhammond) * |
Date: 2002-07-10 02:22 | |
Logged In: YES user_id=14198 The code seems high quality and well documented. I have no concerns with logging.py as such. I have two main issues: * Design decisions: looking over python-dev, I can not see a consensus on the design decisions. I believe that *some* type of official acceptance of the design should be decreed by someone. * Source structure: while this seems quite suitable for an extension module, the format of the patch is probably not quite correct for a core module. For example, the test code should probably be integrated with the standard Python test suite (even if in a sub-directory), the Tex docs integrated with Python's docs etc So while I think the patch is high quality I believe these issues need to be addressed before I can do much more. Setting to "pending" - but good stuff tho! Please drive this through! |
|||
| msg40516 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2002-08-02 21:25 | |
Logged In: YES user_id=6380 Um, Mark, looks like you accidentally closed this! I reopened it and assigned it to me for review. I'm gonna read the PEP and see if I like the design decisions enough to pronounce acceptance. |
|||
| msg40517 - (view) | Author: Vinay Sajip (vinay.sajip) * |
Date: 2002-10-16 09:24 | |
Logged In: YES user_id=308438 The logging.tar.gz is an in-between-releases version which I have uploaded for GvR review. It contains the logging module refactored as a package. __init__.py contains the core including FileHandler and StreamHandler; handlers.py contains all the other handlers; and config.py contains the file- based config stuff. |
|||
| msg40518 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2002-11-13 16:23 | |
Logged In: YES user_id=6380 I've checked this into the Pythonm CVS tree now. I expect to be tweaking it some before the 2.3a1 release. There's no documentation checked in yet; I hope someone will convert the docs at http://www.red-dove.com/python_logging.html to LaTeX. Vinaj, if you have any bug fixes, let me know! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-10 16:05:29 | admin | set | github: 36863 |
| 2002-07-08 00:50:41 | vinay.sajip | create | |